Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IC and monthly forcing file to support BGC for IcoswISC30E3r5 #6272

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

jonbob
Copy link
Contributor

@jonbob jonbob commented Feb 29, 2024

Adds new initial condition and monthly forcing file to support BGC compsets using the IcoswISC30E3r5 resolution.

With thanks to Mat Maltrud for making and providing the new files.

[NML] - only for tests with marine BGC and IcoswISC30E3r5
[BFB] - for all current E3SM tests

@jonbob jonbob added mpas-ocean BFB PR leaves answers BFB BGC labels Feb 29, 2024
@jonbob jonbob requested review from rljacob and maltrud February 29, 2024 23:09
@jonbob jonbob self-assigned this Feb 29, 2024
Copy link

github-actions bot commented Feb 29, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6272/
on branch gh-pages at 2024-03-01 04:49 UTC

@jonbob
Copy link
Contributor Author

jonbob commented Mar 1, 2024

Passed

SMS_Ld2.ne30pg2_r05_IcoswISC30E3r5.BGCEXP_CNTL_CNPRDCTC_1850.chrysalis_intel.elm-bgcexp

but needed a bigger layout than the default testing one

@rljacob
Copy link
Member

rljacob commented Mar 1, 2024

@amametjanov can you adjust the chrysalis test layout for these case and push it to this branch?

@amametjanov
Copy link
Member

Done with 5->9 (fewest) nodes PE-update: https://my.cdash.org/viewTest.php?&buildid=2506848

@jonbob
Copy link
Contributor Author

jonbob commented Mar 1, 2024

Thanks @amametjanov -- I had tested with 8 and 10 nodes, and only the 10-node test passed. So good to know that 9 is enough as well

@rljacob
Copy link
Member

rljacob commented Mar 1, 2024

@ndkeen can you check that this test has enough nodes on Perlmutter?

rljacob added a commit that referenced this pull request Mar 6, 2024
Adds new initial condition and monthly forcing file to support BGC compsets using the IcoswISC30E3r5 resolution.

With thanks to Mat Maltrud for making and providing the new files.

[NML] - only for tests with marine BGC and IcoswISC30E3r5
[BFB] - for all current E3SM tests
@rljacob
Copy link
Member

rljacob commented Mar 6, 2024

merged to next.

@jonbob
Copy link
Contributor Author

jonbob commented Mar 6, 2024

@rljacob -- do you want me to merge this to master and make bless requests?

@rljacob
Copy link
Member

rljacob commented Mar 6, 2024

@jonbob yes please do.

@jonbob jonbob merged commit ee7aeaf into master Mar 6, 2024
10 checks passed
@jonbob jonbob deleted the jonbob/ocn/add-icoswisce3r5-bgc branch March 6, 2024 19:34
@jonbob
Copy link
Contributor Author

jonbob commented Mar 6, 2024

merged to master and expected DIFFs blessed. It's not clear why

SMS_Ld2.ne30pg2_r05_IcoswISC30E3r5.BGCEXP_CNTL_CNPECACNT_1850.pm-cpu_intel.elm-bgcexp

still fails -- it may need investigation if it continues

@rljacob
Copy link
Member

rljacob commented Mar 7, 2024

SMS_Ld2.ne30pg2_r05_IcoswISC30E3r5.BGCEXP_CNTL_CNPECACNT_1850.pm-cpu_intel.elm-bgcexp now says there's no baseline but
SMS_Ld2.ne30pg2_r05_IcoswISC30E3r5.BGCEXP_CNTL_CNPRDCTC_1850.pm-cpu_intel.elm-bgcexp has a runtime fail.

@ndkeen
Copy link
Contributor

ndkeen commented Mar 7, 2024

Verified SMS_Ld2.ne30pg2_r05_IcoswISC30E3r5.BGCEXP_CNTL_CNPRDCTC_1850.pm-cpu_intel.elm-bgcexp passes on next

@jonbob
Copy link
Contributor Author

jonbob commented Mar 11, 2024

I also verified that SMS_Ld2.ne30pg2_r05_IcoswISC30E3r5.BGCEXP_CNTL_CNPRDCTC_1850.pm-cpu_intel.elm-bgcexp passes on next -- I'm not sure what's going on with testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB BGC mpas-ocean
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants