Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change elm restart file for wcprodssp allactive test #5811

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Change elm restart file for wcprodssp allactive test #5811

merged 1 commit into from
Sep 21, 2023

Conversation

peterdschwartz
Copy link
Contributor

Replaced the NaN values for TWS_MONTH_BEGIN with a fill value of 1.e+36 in the elm restart file.

Fixes #5665

@rljacob rljacob added Testing Anything related to unit/system tests Land labels Jul 18, 2023
@bishtgautam
Copy link
Contributor

@ndkeen Is this ready to go?

@bishtgautam
Copy link
Contributor

@peterdschwartz Btw, shouldn't the default finidat value for the compset and the ressolution combination be instead updated?

ndkeen
ndkeen approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@ndkeen ndkeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can verify that the test in github 5665 will now pass with this branch.
SMS_D_Ld1.ne30pg2_EC30to60E2r2.WCYCLSSP370.pm-cpu_intel.allactive-wcprodssp

I also tried with GNU debug.

@peterdschwartz
Copy link
Contributor Author

@bishtgautam That sounds like the best approach. I'll look into fixing it that way.

@rljacob rljacob mentioned this pull request Aug 10, 2023
Merged
@rljacob
Copy link
Member

rljacob commented Aug 10, 2023

Notes: waiting on better fix.

@peterdschwartz
Copy link
Contributor Author

@bishtgautam The input files for this test are set using REFCASE so there's not (that I could find) a compset definition for the finidat file. So I don't think a more general solution is available for this test. Let me know if I'm missing something -- I just looked through all the compset and namelist definition XML files.

@bishtgautam
Copy link
Contributor

Ok, I will merge this PR.

@rljacob
Copy link
Member

rljacob commented Sep 7, 2023

@bishtgautam please merge.

bishtgautam added a commit that referenced this pull request Sep 7, 2023
@bishtgautam
Merge branch 'peterdschwartz/lnd/remove-nan-from-v2-restart' into nex…
9fb3015 
…t (PR #5811)

Replaced the NaN values for TWS_MONTH_BEGIN with a fill value of 1.e+36 in the elm restart file.

Fixes #5665
@bishtgautam
Copy link
Contributor

merged to next

@rljacob
Copy link
Member

rljacob commented Sep 21, 2023

@bishtgautam merge to master.

@rljacob
Copy link
Member

rljacob commented Sep 21, 2023

Test results are impacted by v3atm merges which have disabled ssp from running.

@bishtgautam bishtgautam merged commit e61ff92 into E3SM-Project:master Sep 21, 2023
1 check passed
This was referenced Jan 19, 2024
Closed
Merged
@beharrop beharrop mentioned this pull request Jan 30, 2024
Closed
@peterdschwartz peterdschwartz mentioned this pull request Feb 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndkeen ndkeen ndkeen approved these changes

Assignees

@bishtgautam bishtgautam

Labels
bug fix PR Land Testing Anything related to unit/system tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

floating invalid with SMS_D_Ld1.ne30pg2_EC30to60E2r2.WCYCLSSP370.pm-cpu_intel.allactive-wcprodssp
4 participants
@peterdschwartz @bishtgautam @rljacob @ndkeen