Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turns on debugging for multiple land tests. #5599

Merged
merged 3 commits into from
Jun 8, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions cime_config/tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
"ERS.f09_g16.I1850GSWCNPRDCTCBC.elm-vstrd",
"ERS.f19_g16.I1850GSWCNPECACNTBC.elm-eca_f19_g16_I1850GSWCNPECACNTBC",
"ERS.f19_g16.I20TRGSWCNPECACNTBC.elm-eca_f19_g16_I20TRGSWCNPECACNTBC",
"ERS.f19_g16.I1850GSWCNPRDCTCBC.elm-ctc_f19_g16_I1850GSWCNPRDCTCBC",
"ERS.f19_g16.I20TRGSWCNPRDCTCBC.elm-ctc_f19_g16_I20TRGSWCNPRDCTCBC",
)
},
Expand All @@ -52,33 +51,41 @@
)
},

"e3sm_land_debug" : {
"time" : "0:45:00",
"tests" : (
"ERS_D.f19_f19.IELM.elm-ic_f19_f19_ielm",
"ERS_D.f09_g16.I1850ELMCN",
"ERS_D.ne11_oQU240.I20TRELM",
"SMS_Ly2_P1x1_D.1x1_smallvilleIA.IELMCNCROP.elm-lulcc_sville",
"ERS_D.f19_g16.I1850GSWCNPRDCTCBC.elm-ctc_f19_g16_I1850GSWCNPRDCTCBC",
"ERS_D.f09_f09.IELM.elm-solar_rad",
"ERS_D.f09_f09.IELM.elm-koch_snowflake",
"SMS_Ld20_D.f45_f45.IELMFATES.elm-fates_rd",
"SMS_Ld30_D.f45_f45.IELMFATES.elm-fates_satphen"
)
},


"e3sm_land_developer" : {
"share" : True,
"time" : "0:45:00",
"inherit" : ("e3sm_mosart_developer", "e3sm_mosart_exenoshare", "e3sm_land_exeshare", "e3sm_land_exenoshare"),
"inherit" : ("e3sm_mosart_developer", "e3sm_mosart_exenoshare", "e3sm_land_exeshare", "e3sm_land_exenoshare", "e3sm_land_debug"),
"tests" : (
"ERS.f19_f19.IELM.elm-ic_f19_f19_ielm",
"ERS.f19_f19.I1850ELMCN",
"ERS.f09_g16.I1850ELMCN",
"ERS.f19_f19.I20TRELMCN",
"SMS_Ld1.hcru_hcru.I1850CRUELMCN",
"SMS_Ly2_P1x1.1x1_smallvilleIA.IELMCNCROP.elm-force_netcdf_pio",
"SMS_Ld20.f45_f45.IELMFATES.elm-fates_rd",
"SMS_Ld20.f45_f45.IELMFATES.elm-fates_eca",
"SMS_Ld30.f45_f45.IELMFATES.elm-fates_satphen",
"ERS.f19_g16.I1850ELM.elm-betr",
"ERS.f19_g16.I1850ELM.elm-vst",
"ERS.f09_g16.I1850ELMCN.elm-bgcinterface",
"ERS.ne11_oQU240.I20TRELM",
"SMS.r05_r05.I1850ELMCN.elm-qian_1948",
"SMS_Ly2_P1x1.1x1_smallvilleIA.IELMCNCROP.elm-lulcc_sville",
"SMS_Ly2_P1x1.1x1_smallvilleIA.IELMCNCROP.elm-per_crop",
"SMS.r05_r05.IELM.elm-topounit",
"ERS.ELM_USRDAT.I1850ELM.elm-usrdat",
"ERS.r05_r05.IELM.elm-V2_ELM_MOSART_features",
"ERS.f09_f09.IELM.elm-solar_rad",
"ERS.f09_f09.IELM.elm-lnd_rof_2way",
"ERS.f09_f09.IELM.elm-koch_snowflake"
"ERS.r05_r05.IELM.elm-V2_ELM_MOSART_features"
)
},

Expand Down
1 change: 1 addition & 0 deletions components/elm/src/biogeochem/PhenologyMod.F90
Original file line number Diff line number Diff line change
Expand Up @@ -376,6 +376,7 @@ subroutine PhenologyInit(bounds)
! average 2m temp.
! crit_onset_gdd = 150.0 ! c3 grass value
! crit_onset_gdd = 1000.0 ! c4 grass value
crit_onset_fdd=PhenolParamsInst%crit_onset_fdd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change related to running a debug test or an open issue?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it should be removed if it's tangential to the debug tests -- just thinking the PR description should mention it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix is needed to allow the few BGC tests to pass when debugging is turned on.

crit_onset_swi=PhenolParamsInst%crit_onset_swi
soilpsi_on=PhenolParamsInst%soilpsi_on

Expand Down