Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable C-based harvest in ELM-FATES and update to FATES API 25 #5429

Merged

Conversation

glemieux
Copy link
Contributor

@glemieux glemieux commented Feb 2, 2023

This pull request contains modification in E3SM corresponding to another FATES
NGEET/fates#888. In detail, the necessary input to enable
FATES C-based harvest from ELM is passed to FATES through bc_in. Output
from FATES used to calculate land use emission and net biosphere productivity
is passed to ELM through bc_out.

[non-B4B] (FATES tests only)

@glemieux
Copy link
Contributor Author

glemieux commented Feb 2, 2023

Note that this PR is the rebase of #5106. Land dev test results forthcoming.

@glemieux
Copy link
Contributor Author

glemieux commented Feb 2, 2023

@bishtgautam regression testing against master on perlmutter (pm-cpu) is B4B with the exception of the fates tests, which is as expected. Four non-FATES tests saw TPUTCOMP increases.

Folder location: /global/homes/g/glemieux/pm-scratch/e3sm-tests/pr5109-rebase.fates.pm-cpu.gnu.C11b9f1c4ae-F77753581

@bishtgautam
Copy link
Contributor

Hey @rgknox , can you also review this PR? thanks.

bishtgautam added a commit that referenced this pull request Feb 13, 2023
This pull request contains modification in E3SM corresponding to another FATES
NGEET/fates#888. In detail, the necessary input to enable
FATES C-based harvest from ELM is passed to FATES through bc_in. Output
from FATES used to calculate land use emission and net biosphere productivity
is passed to ELM through bc_out.

[non-B4B] (FATES tests only)
@bishtgautam
Copy link
Contributor

Merged to next.

@bishtgautam bishtgautam merged commit b645be3 into E3SM-Project:master Feb 14, 2023
@glemieux glemieux deleted the glemieux/lnd/fatesluc_cbasedhrv_v2 branch January 23, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants