theta nonhydrostatic model updates to DCMIP test cases #2600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and not duplicate the buggy nu_div scaling from PREQX
new KGS542 scheme from A. Steyer with better stability properties PHI_ref used in hyperviscosity computed from dp_ref, theta_ref instead of from prognostic variables created configurations and/or updated namelists for theta-l: dcmip2012 test2.0 dcmip2012 test4.1 dcmip2016 test1, test2, test3 non-BFB for theta model
heating term appears to be buggy. it destablizes dcmip2016 test1
consistency check only makes sense in dry test cases. in moist test cases, q1 forcing is also applied to dp3d and so it is not possible to check consistency with a q=1 tracer.
…t cases" This reverts commit 30c53fd. test case IC code sets 6 tracers, so we need qsize>=6 for all namelists
Instabilities were being caused by a buggy heating term. Disabling for now. The heating term appears to also have been responsible for instabilities previously blamed on the reference profiles used in the hyperviscosity operator. With heating term disabled, reverting back to the original more accurate reference profiles.
also moved vertical_levels_init2 out of prim_advance_mod.F90 and into model_init_mod.F90
create subcommunicator for each node workaround for non-scalable memory used by GridVertex and GridEdge arrays This sequentilizes the domain decomposition and scheduling operations. Timing is given in new timer, ScheduleTime Need to perform ne512 and ne1024 benchmarks and see how much this slows down the initialization
only force sequential initialization if we will be processing more than 40M elements per node.
tuned number of active MPI tasks per node during init serialization to minimize init time on KNL
incorrect array dimension when calling make_c0_vector()
two bug fixes: TC (test2) was ignoring mosture when computing initial vtheta_dp dcmip2016 wrapper code was computing z_i (interface position) from z_m. this was changed to use the model's native versoin of z_i
DCMIP2016 forcing functions are expecting dry mixing rations and we were sending wet mixing ratios
with bug fix, update DCMIP forcing functions to return correct Temperature
R&J physics avoids grid point storms seen with Kessler physics, allows most test cases to run with rsplit=6
ne512 and ne1024 namelists which run for 2h, with large rsplit and R&J physics
now all tests run with rsplit=6
mt5555
added a commit
that referenced
this pull request
Oct 28, 2018
updates to DCMIP2016 test cases for NH theta model bug fixes in forcing functions (use dry mixing ratios, convesion between theta and temperature) moisture was ignored for some initial conditions heating term was buggy - disabled for now switch default namelists from Kessler physics to R&J physics so we can run with large remap timesteps update all namelists to run with recommended timesteps [BFB] except for some HOMME subtest
mt5555
added a commit
that referenced
this pull request
Oct 29, 2018
remerge this branch to fix GNU compiler issue
mt5555
added a commit
that referenced
this pull request
Oct 29, 2018
updates to DCMIP2016 test cases for NH theta model bug fixes in forcing functions (use dry mixing ratios, convesion between theta and temperature) moisture was ignored for some initial conditions heating term was buggy - disabled for now switch default namelists from Kessler physics to R&J physics so we can run with large remap timesteps update all namelists to run with recommended timesteps [BFB] except for some HOMME subtests
jgfouca
pushed a commit
that referenced
this pull request
Jan 18, 2024
…iffs Automatically Merged using E3SM Pull Request AutoTester PR Title: Fix chrysalis cmake macro to fix DIFFs PR Author: jgfouca PR LABELS: AT: AUTOMERGE, AT: Integrate Without Testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates to DCMIP2016 test cases for NH theta model
bug fixes in forcing functions (use dry mixing ratios, convesion between theta and temperature)
moisture was ignored for some initial conditions
heating term was buggy - disabled for now
switch default namelists from Kessler physics to R&J physics so we can run with large remap timesteps
update all namelists to run with recommended timesteps
[BFB] except for some HOMME subtests