Variable name change to MAX_MPITASKS_PER_NODE for edison #1888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Variable name change to MAX_MPITASKS_PER_NODE And modify -c flag to account for threads. If using hyper-threads, make sure to change MAX_TASKS_PER_NODE. No change if not using threads.
ndkeen
added a commit
that referenced
this pull request
Nov 6, 2017
…t (PR #1888) For edison only: Variable name change to MAX_MPITASKS_PER_NODE And modify -c flag to account for threads. If using hyper-threads, make sure to change MAX_TASKS_PER_NODE. No change if not using threads. [BFB]
ndkeen
added a commit
that referenced
this pull request
Nov 7, 2017
|
Are you sure about this? |
|
My intention here was to simply back out the changes to edison (so that there would be no conflicts) as we are making those changes already in PR 1888. And this PR should only be for Cori. It's possible I did something wrong. Should I make another PR to avoid confusion? |
|
Did you test? E.g.: |
|
Are you concerned about this PR or PR 1888? |
|
The name change was from PES_PER_NODE to MAX_MPITASKS_PER_NODE. |
This reverts commit ccb0042.
Adjust the -c flag to srun, affecting hyper-threading.
|
reverted, making another |
jgfouca
pushed a commit
to ESMCI/cime
that referenced
this pull request
Nov 13, 2017
jgfouca
added a commit
that referenced
this pull request
Nov 13, 2017
…branch-for-to-acme-11-13-2017-pr * commit '9442c938717a641d50c9ed5a0f9b2d34cf35a4ea': fix pylint issue rename locked files needs to handle BUILD_COMPLETE better Switch melvin to use officially supported pfunit add optional COST_PER_NODE Remove hardcoded email options for lc_slurm, cascade, constance, sooty Fix cobalt indent Remove hardcoded mail option for PBS Revert "Revert the change to edison as this is now in #1888" Revert the change to edison as this is now in #1888 Undo/remove things that keep causing problems in the ESMCI merge. Update Slurm task-to-core affinities Efficiency updates for coupler bypass
jgfouca
added a commit
that referenced
this pull request
Nov 13, 2017
…1896) Update cime to ESMCI 5.4.0-alpha.09 Feature list: Add optional COSTPES_PER_NODE field Bugfix for checking locked files, BUILD_COMPLETE should not cause check to fail [BFB] * jgfouca/branch-for-to-acme-11-13-2017-pr: fix pylint issue rename locked files needs to handle BUILD_COMPLETE better Switch melvin to use officially supported pfunit add optional COST_PER_NODE Remove hardcoded email options for lc_slurm, cascade, constance, sooty Fix cobalt indent Remove hardcoded mail option for PBS Revert "Revert the change to edison as this is now in #1888" Revert the change to edison as this is now in #1888 Undo/remove things that keep causing problems in the ESMCI merge. Update Slurm task-to-core affinities Efficiency updates for coupler bypass
jgfouca
added a commit
that referenced
this pull request
Nov 14, 2017
#1896) Update cime to ESMCI 5.4.0-alpha.09 Feature list: Add optional COSTPES_PER_NODE field Bugfix for checking locked files, BUILD_COMPLETE should not cause check to fail [BFB] * jgfouca/branch-for-to-acme-11-13-2017-pr: fix pylint issue rename locked files needs to handle BUILD_COMPLETE better Switch melvin to use officially supported pfunit add optional COST_PER_NODE Remove hardcoded email options for lc_slurm, cascade, constance, sooty Fix cobalt indent Remove hardcoded mail option for PBS Revert "Revert the change to edison as this is now in #1888" Revert the change to edison as this is now in #1888 Undo/remove things that keep causing problems in the ESMCI merge. Update Slurm task-to-core affinities Efficiency updates for coupler bypass
jgfouca
added a commit
to ESMCI/cime
that referenced
this pull request
Dec 8, 2017
#1896) Update cime to ESMCI 5.4.0-alpha.09 Feature list: Add optional COSTPES_PER_NODE field Bugfix for checking locked files, BUILD_COMPLETE should not cause check to fail [BFB] * jgfouca/branch-for-to-acme-11-13-2017-pr: fix pylint issue rename locked files needs to handle BUILD_COMPLETE better Switch melvin to use officially supported pfunit add optional COST_PER_NODE Remove hardcoded email options for lc_slurm, cascade, constance, sooty Fix cobalt indent Remove hardcoded mail option for PBS Revert "Revert the change to edison as this is now in E3SM-Project/E3SM#1888" Revert the change to edison as this is now in E3SM-Project/E3SM#1888 Undo/remove things that keep causing problems in the ESMCI merge. Update Slurm task-to-core affinities Efficiency updates for coupler bypass
jgfouca
pushed a commit
to ESMCI/cime
that referenced
this pull request
Feb 23, 2018
jgfouca
added a commit
to ESMCI/cime
that referenced
this pull request
Feb 23, 2018
…branch-for-to-acme-11-13-2017-pr * commit '9442c938717a641d50c9ed5a0f9b2d34cf35a4ea': fix pylint issue rename locked files needs to handle BUILD_COMPLETE better Switch melvin to use officially supported pfunit add optional COST_PER_NODE Remove hardcoded email options for lc_slurm, cascade, constance, sooty Fix cobalt indent Remove hardcoded mail option for PBS Revert "Revert the change to edison as this is now in E3SM-Project/E3SM#1888" Revert the change to edison as this is now in E3SM-Project/E3SM#1888 Undo/remove things that keep causing problems in the ESMCI merge. Update Slurm task-to-core affinities Efficiency updates for coupler bypass
jgfouca
added a commit
to ESMCI/cime
that referenced
this pull request
Feb 23, 2018
#1896) Update cime to ESMCI 5.4.0-alpha.09 Feature list: Add optional COSTPES_PER_NODE field Bugfix for checking locked files, BUILD_COMPLETE should not cause check to fail [BFB] * jgfouca/branch-for-to-acme-11-13-2017-pr: fix pylint issue rename locked files needs to handle BUILD_COMPLETE better Switch melvin to use officially supported pfunit add optional COST_PER_NODE Remove hardcoded email options for lc_slurm, cascade, constance, sooty Fix cobalt indent Remove hardcoded mail option for PBS Revert "Revert the change to edison as this is now in E3SM-Project/E3SM#1888" Revert the change to edison as this is now in E3SM-Project/E3SM#1888 Undo/remove things that keep causing problems in the ESMCI merge. Update Slurm task-to-core affinities Efficiency updates for coupler bypass
jgfouca
pushed a commit
to ESMCI/cime
that referenced
this pull request
Mar 13, 2018
jgfouca
added a commit
to ESMCI/cime
that referenced
this pull request
Mar 13, 2018
…branch-for-to-acme-11-13-2017-pr * commit '9442c938717a641d50c9ed5a0f9b2d34cf35a4ea': fix pylint issue rename locked files needs to handle BUILD_COMPLETE better Switch melvin to use officially supported pfunit add optional COST_PER_NODE Remove hardcoded email options for lc_slurm, cascade, constance, sooty Fix cobalt indent Remove hardcoded mail option for PBS Revert "Revert the change to edison as this is now in E3SM-Project/E3SM#1888" Revert the change to edison as this is now in E3SM-Project/E3SM#1888 Undo/remove things that keep causing problems in the ESMCI merge. Update Slurm task-to-core affinities Efficiency updates for coupler bypass
jgfouca
added a commit
to ESMCI/cime
that referenced
this pull request
Mar 13, 2018
#1896) Update cime to ESMCI 5.4.0-alpha.09 Feature list: Add optional COSTPES_PER_NODE field Bugfix for checking locked files, BUILD_COMPLETE should not cause check to fail [BFB] * jgfouca/branch-for-to-acme-11-13-2017-pr: fix pylint issue rename locked files needs to handle BUILD_COMPLETE better Switch melvin to use officially supported pfunit add optional COST_PER_NODE Remove hardcoded email options for lc_slurm, cascade, constance, sooty Fix cobalt indent Remove hardcoded mail option for PBS Revert "Revert the change to edison as this is now in E3SM-Project/E3SM#1888" Revert the change to edison as this is now in E3SM-Project/E3SM#1888 Undo/remove things that keep causing problems in the ESMCI merge. Update Slurm task-to-core affinities Efficiency updates for coupler bypass
sjsprecious
pushed a commit
to sjsprecious/CAM
that referenced
this pull request
Oct 5, 2020
…branch-for-to-acme-11-13-2017-pr * commit '9442c938717a641d50c9ed5a0f9b2d34cf35a4ea': fix pylint issue rename locked files needs to handle BUILD_COMPLETE better Switch melvin to use officially supported pfunit add optional COST_PER_NODE Remove hardcoded email options for lc_slurm, cascade, constance, sooty Fix cobalt indent Remove hardcoded mail option for PBS Revert "Revert the change to edison as this is now in E3SM-Project/E3SM#1888" Revert the change to edison as this is now in E3SM-Project/E3SM#1888 Undo/remove things that keep causing problems in the ESMCI merge. Update Slurm task-to-core affinities Efficiency updates for coupler bypass
sjsprecious
pushed a commit
to sjsprecious/CAM
that referenced
this pull request
Oct 5, 2020
…PR #1896) Update cime to ESMCI 5.4.0-alpha.09 Feature list: Add optional COSTPES_PER_NODE field Bugfix for checking locked files, BUILD_COMPLETE should not cause check to fail [BFB] * jgfouca/branch-for-to-acme-11-13-2017-pr: fix pylint issue rename locked files needs to handle BUILD_COMPLETE better Switch melvin to use officially supported pfunit add optional COST_PER_NODE Remove hardcoded email options for lc_slurm, cascade, constance, sooty Fix cobalt indent Remove hardcoded mail option for PBS Revert "Revert the change to edison as this is now in E3SM-Project/E3SM#1888" Revert the change to edison as this is now in E3SM-Project/E3SM#1888 Undo/remove things that keep causing problems in the ESMCI merge. Update Slurm task-to-core affinities Efficiency updates for coupler bypass
fischer-ncar
pushed a commit
to fischer-ncar/Tasks
that referenced
this pull request
Jan 27, 2021
…branch-for-to-acme-11-13-2017-pr * commit '9442c938717a641d50c9ed5a0f9b2d34cf35a4ea': fix pylint issue rename locked files needs to handle BUILD_COMPLETE better Switch melvin to use officially supported pfunit add optional COST_PER_NODE Remove hardcoded email options for lc_slurm, cascade, constance, sooty Fix cobalt indent Remove hardcoded mail option for PBS Revert "Revert the change to edison as this is now in E3SM-Project/E3SM#1888" Revert the change to edison as this is now in E3SM-Project/E3SM#1888 Undo/remove things that keep causing problems in the ESMCI merge. Update Slurm task-to-core affinities Efficiency updates for coupler bypass
fischer-ncar
pushed a commit
to fischer-ncar/Tasks
that referenced
this pull request
Jan 27, 2021
…PR #1896) Update cime to ESMCI 5.4.0-alpha.09 Feature list: Add optional COSTPES_PER_NODE field Bugfix for checking locked files, BUILD_COMPLETE should not cause check to fail [BFB] * jgfouca/branch-for-to-acme-11-13-2017-pr: fix pylint issue rename locked files needs to handle BUILD_COMPLETE better Switch melvin to use officially supported pfunit add optional COST_PER_NODE Remove hardcoded email options for lc_slurm, cascade, constance, sooty Fix cobalt indent Remove hardcoded mail option for PBS Revert "Revert the change to edison as this is now in E3SM-Project/E3SM#1888" Revert the change to edison as this is now in E3SM-Project/E3SM#1888 Undo/remove things that keep causing problems in the ESMCI merge. Update Slurm task-to-core affinities Efficiency updates for coupler bypass
fischer-ncar
pushed a commit
to ESCOMP/CESM_share
that referenced
this pull request
Apr 9, 2021
…branch-for-to-acme-11-13-2017-pr * commit '9442c938717a641d50c9ed5a0f9b2d34cf35a4ea': fix pylint issue rename locked files needs to handle BUILD_COMPLETE better Switch melvin to use officially supported pfunit add optional COST_PER_NODE Remove hardcoded email options for lc_slurm, cascade, constance, sooty Fix cobalt indent Remove hardcoded mail option for PBS Revert "Revert the change to edison as this is now in E3SM-Project/E3SM#1888" Revert the change to edison as this is now in E3SM-Project/E3SM#1888 Undo/remove things that keep causing problems in the ESMCI merge. Update Slurm task-to-core affinities Efficiency updates for coupler bypass
fischer-ncar
pushed a commit
to ESCOMP/CESM_share
that referenced
this pull request
Apr 9, 2021
…PR #1896) Update cime to ESMCI 5.4.0-alpha.09 Feature list: Add optional COSTPES_PER_NODE field Bugfix for checking locked files, BUILD_COMPLETE should not cause check to fail [BFB] * jgfouca/branch-for-to-acme-11-13-2017-pr: fix pylint issue rename locked files needs to handle BUILD_COMPLETE better Switch melvin to use officially supported pfunit add optional COST_PER_NODE Remove hardcoded email options for lc_slurm, cascade, constance, sooty Fix cobalt indent Remove hardcoded mail option for PBS Revert "Revert the change to edison as this is now in E3SM-Project/E3SM#1888" Revert the change to edison as this is now in E3SM-Project/E3SM#1888 Undo/remove things that keep causing problems in the ESMCI merge. Update Slurm task-to-core affinities Efficiency updates for coupler bypass
rljacob
pushed a commit
that referenced
this pull request
Apr 21, 2021
…branch-for-to-acme-11-13-2017-pr * commit '3915cfda8866df152183f2b49f7b095142c50523': fix pylint issue rename locked files needs to handle BUILD_COMPLETE better Switch melvin to use officially supported pfunit add optional COST_PER_NODE Remove hardcoded email options for lc_slurm, cascade, constance, sooty Fix cobalt indent Remove hardcoded mail option for PBS Revert "Revert the change to edison as this is now in #1888" Revert the change to edison as this is now in #1888 Undo/remove things that keep causing problems in the ESMCI merge. Update Slurm task-to-core affinities Efficiency updates for coupler bypass
rljacob
pushed a commit
that referenced
this pull request
Apr 21, 2021
…branch-for-to-acme-11-13-2017-pr * commit '3915cfda8866df152183f2b49f7b095142c50523': fix pylint issue rename locked files needs to handle BUILD_COMPLETE better Switch melvin to use officially supported pfunit add optional COST_PER_NODE Remove hardcoded email options for lc_slurm, cascade, constance, sooty Fix cobalt indent Remove hardcoded mail option for PBS Revert "Revert the change to edison as this is now in #1888" Revert the change to edison as this is now in #1888 Undo/remove things that keep causing problems in the ESMCI merge. Update Slurm task-to-core affinities Efficiency updates for coupler bypass
rljacob
pushed a commit
that referenced
this pull request
Apr 21, 2021
#1896) Update cime to ESMCI 5.4.0-alpha.09 Feature list: Add optional COSTPES_PER_NODE field Bugfix for checking locked files, BUILD_COMPLETE should not cause check to fail [BFB] * jgfouca/branch-for-to-acme-11-13-2017-pr: fix pylint issue rename locked files needs to handle BUILD_COMPLETE better Switch melvin to use officially supported pfunit add optional COST_PER_NODE Remove hardcoded email options for lc_slurm, cascade, constance, sooty Fix cobalt indent Remove hardcoded mail option for PBS Revert "Revert the change to edison as this is now in #1888" Revert the change to edison as this is now in #1888 Undo/remove things that keep causing problems in the ESMCI merge. Update Slurm task-to-core affinities Efficiency updates for coupler bypass
ekluzek
pushed a commit
to ekluzek/mizuRoute
that referenced
this pull request
Nov 30, 2022
…branch-for-to-acme-11-13-2017-pr * commit '0664ddcbb0b1e6c64f094f97926c2e9be54d0288': fix pylint issue rename locked files needs to handle BUILD_COMPLETE better Switch melvin to use officially supported pfunit add optional COST_PER_NODE Remove hardcoded email options for lc_slurm, cascade, constance, sooty Fix cobalt indent Remove hardcoded mail option for PBS Revert "Revert the change to edison as this is now in E3SM-Project/E3SM#1888" Revert the change to edison as this is now in E3SM-Project/E3SM#1888 Undo/remove things that keep causing problems in the ESMCI merge. Update Slurm task-to-core affinities Efficiency updates for coupler bypass
ekluzek
pushed a commit
to ekluzek/mizuRoute
that referenced
this pull request
Nov 30, 2022
…PR #1896) Update cime to ESMCI 5.4.0-alpha.09 Feature list: Add optional COSTPES_PER_NODE field Bugfix for checking locked files, BUILD_COMPLETE should not cause check to fail [BFB] * jgfouca/branch-for-to-acme-11-13-2017-pr: fix pylint issue rename locked files needs to handle BUILD_COMPLETE better Switch melvin to use officially supported pfunit add optional COST_PER_NODE Remove hardcoded email options for lc_slurm, cascade, constance, sooty Fix cobalt indent Remove hardcoded mail option for PBS Revert "Revert the change to edison as this is now in E3SM-Project/E3SM#1888" Revert the change to edison as this is now in E3SM-Project/E3SM#1888 Undo/remove things that keep causing problems in the ESMCI merge. Update Slurm task-to-core affinities Efficiency updates for coupler bypass
billsacks
pushed a commit
to billsacks/cprnc
that referenced
this pull request
Dec 2, 2023
…branch-for-to-acme-11-13-2017-pr * commit '2bea72733aafbb32b497eacc902bb58918dccdb4': fix pylint issue rename locked files needs to handle BUILD_COMPLETE better Switch melvin to use officially supported pfunit add optional COST_PER_NODE Remove hardcoded email options for lc_slurm, cascade, constance, sooty Fix cobalt indent Remove hardcoded mail option for PBS Revert "Revert the change to edison as this is now in E3SM-Project/E3SM#1888" Revert the change to edison as this is now in E3SM-Project/E3SM#1888 Undo/remove things that keep causing problems in the ESMCI merge. Update Slurm task-to-core affinities Efficiency updates for coupler bypass
billsacks
pushed a commit
to billsacks/cprnc
that referenced
this pull request
Dec 2, 2023
…branch-for-to-acme-11-13-2017-pr * commit '2bea72733aafbb32b497eacc902bb58918dccdb4': fix pylint issue rename locked files needs to handle BUILD_COMPLETE better Switch melvin to use officially supported pfunit add optional COST_PER_NODE Remove hardcoded email options for lc_slurm, cascade, constance, sooty Fix cobalt indent Remove hardcoded mail option for PBS Revert "Revert the change to edison as this is now in E3SM-Project/E3SM#1888" Revert the change to edison as this is now in E3SM-Project/E3SM#1888 Undo/remove things that keep causing problems in the ESMCI merge. Update Slurm task-to-core affinities Efficiency updates for coupler bypass
billsacks
pushed a commit
to billsacks/cprnc
that referenced
this pull request
Dec 2, 2023
…PR #1896) Update cime to ESMCI 5.4.0-alpha.09 Feature list: Add optional COSTPES_PER_NODE field Bugfix for checking locked files, BUILD_COMPLETE should not cause check to fail [BFB] * jgfouca/branch-for-to-acme-11-13-2017-pr: fix pylint issue rename locked files needs to handle BUILD_COMPLETE better Switch melvin to use officially supported pfunit add optional COST_PER_NODE Remove hardcoded email options for lc_slurm, cascade, constance, sooty Fix cobalt indent Remove hardcoded mail option for PBS Revert "Revert the change to edison as this is now in E3SM-Project/E3SM#1888" Revert the change to edison as this is now in E3SM-Project/E3SM#1888 Undo/remove things that keep causing problems in the ESMCI merge. Update Slurm task-to-core affinities Efficiency updates for coupler bypass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For edison only:
Variable name change to MAX_MPITASKS_PER_NODE
And modify -c flag to account for threads. If using hyper-threads, make sure to change MAX_TASKS_PER_NODE.
No change if not using threads.
[BFB]