Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build fails with SMS_Ln3.ne4pg2_ne4pg2.F2010-MMF2 #6363

Closed
ndkeen opened this issue Apr 23, 2024 · 1 comment · Fixed by #6354
Closed

build fails with SMS_Ln3.ne4pg2_ne4pg2.F2010-MMF2 #6363

ndkeen opened this issue Apr 23, 2024 · 1 comment · Fixed by #6354
Labels
CMake build system MMF

Comments

@ndkeen
Copy link
Contributor

ndkeen commented Apr 23, 2024

Likely due to a change in cmake made in scream repo that was merged into E3SM.

SMS_Ln3.ne4pg2_ne4pg2.F2010-MMF2.pm-cpu_gnu (as well as intel) fails to build:

-- Configuring done
CMake Error at eam/src/physics/crm/pam/external/physics/scream_cxx_p3_shoc/scream_share/CMakeLists.txt:35 (add_library):
  Cannot find source file:

    /global/cfs/cdirs/e3sm/ndk/repos/me26-apr22/components/eamxx/src/share/grid/remap/horizontal_remap_utility.cpp

  Tried extensions .c .C .c++ .cc .cpp .cxx .cu .mpp .m .M .mm .ixx .cppm .h
  .hh .h++ .hm .hpp .hxx .in .txx .f .F .for .f77 .f90 .f95 .f03 .hip .ispc


CMake Error at eam/src/physics/crm/pam/external/physics/scream_cxx_p3_shoc/scream_share/CMakeLists.txt:35 (add_library):
  No SOURCES given to target: scream_share


CMake Generate step failed.  Build files cannot be regenerated correctly.
@whannah1 whannah1 mentioned this issue Apr 25, 2024
Merged
@ndkeen
Copy link
Contributor Author

ndkeen commented Jul 25, 2024

Noting this has been failing in a stable manner for 3 months

brhillman added a commit that referenced this issue Aug 21, 2024
@brhillman
Merge branch 'whannah/mmf/pam-updates' into next (#6354)
ff95def 
This brings in several updates and fixes for the PAM CRM used in the MMF2 compsets to improve stability and throughput. Some of these required updates to the PAM submodule, but the most important change was the addition of adaptive sub-cycling in the PAM driver. This change allowed the CRM time step to be increased to 10 seconds, which dramatically improved the throughput while also making the model much more resilient to numerically unstable conditions due to unrealistically strong velocities (still not sure why these occur in the first place).

List of notable changes for PAM and/or the driver:

adaptive subcycling in PAM driver
enable variance transport by default
disable mean-state acceleration for dry density
use crm_nx=45 with exact interpolation for PAM dycor (requires odd CRM columns)
increase PAM hyperdiffusion timescale to 60 seconds to reduce over-smoothing
Fixes #6363

[non-BFB] only for MMF2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CMake build system MMF
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Major MMF2/PAM updates E3SM-Project/E3SM
1 participant
@ndkeen