-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate removal of Antarctic river and ice runoff #105
Separate removal of Antarctic river and ice runoff #105
Conversation
The totals are computed incorrectly (they are missing areaCell) and are not currently used for anything within MPAS-Ocean or any diagnostics.
This is needed so so we can remove ice (solid) runoff but not river (liquid) runoff.
@darincomeau and @cbegeman, I'm testing this now and will post the results. Once I've successfully tested this, I'd appreciate your review. |
I'm afraid I don't recall why I closed #103 a few days ago. Perhaps that was a mistake. Anyway, this replaces it. Also, E3SM-Project#6413 has gone into E3SM master so I think this change now makes more sense. |
TestingI ran a another test to make sure river runoff was being removed and ice runoff was not. Results are in:
As expected, I'm seeing:
Basically the same as my SORRM test in #103 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on visual inspection and @xylar's testing. Let me know if you'd like me to do any additional testing.
Passes
with expected values for I also ran a branch test off the v3.LR.spinup to see if the change in ocn namelist would have an adverse impact, and it did not, ran fine. @xylar I agree with the change in removing AIS river runoff in CRYO configurations (i.e. to not do it anymore), in the real PR can you put that behavior change in the header? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved based on visual inspection, developer and above testing.
Thank you both! I'll move this over to E3SM. |
Moving to E3SM-Project#6510 |
This is needed so we can remove ice (solid) runoff but not river (liquid) runoff.
This merge aslo removes
totalRemoved*RunoffFlux
variables. These fields are computed incorrectly (they are missingareaCell
) and are not currently used for anything within MPAS-Ocean or any diagnostics.This is part of the design: https://acme-climate.atlassian.net/wiki/spaces/PSC/pages/4210098268/Design+Document+Data+iceberg+and+ice-shelf+melt+flux+patterns+for+E3SM+spin-up+runs
This is a high priority for the Polar team.