Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/enable rate limiter for account clients #1605

Merged
merged 7 commits into from
Oct 15, 2024
Merged

Fix/enable rate limiter for account clients #1605

merged 7 commits into from
Oct 15, 2024

Conversation

warber
Copy link
Contributor

@warber warber commented Oct 15, 2024 •
edited
Loading

What this PR does / Why we need it:

This PR enables the rate limiter as well as retry settings when creating clients for account management.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Monaco handles HTTP 429 Too many requests errors correctly

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 15, 2024 •
edited
Loading

Unit Test Results

1 889 tests  ±0   1 888 ✅ ±0   1m 58s ⏱️ -1s
  133 suites ±0       1 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit ee099f5. ± Comparison against base commit 7805260.

♻️ This comment has been updated with latest results.

@warber warber added the run-iam-test Manually trigger Account Management E2E tests for PRs label Oct 15, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 15, 2024 •
edited
Loading

E2E Test Results

1 files   -     3  1 suites   - 267   11m 0s ⏱️ - 15m 37s
2 tests  - 1 999  1 ✅  - 1 998  0 💤  - 2  1 ❌ +1 
2 runs   - 2 114  1 ✅  - 2 113  0 💤  - 2  1 ❌ +1 

For more details on these failures, see this check.

Results for commit d07b81e. ± Comparison against base commit dcb1f86.

This pull request removes 2001 and adds 2 tests. Note that renamed tests count towards both. 
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/account ‑ TestLoadResources
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/account ‑ TestLoadResources_Duplicates
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/account ‑ TestLoadResources_Duplicates/Load_Resources_-_duplicate_group
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/account ‑ TestLoadResources_Duplicates/Load_Resources_-_duplicate_policy
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/account ‑ TestLoadResources_Duplicates/Load_Resources_-_duplicate_user
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/convert ‑ TestConvert_FailsIfThereIsJustEmptyProjects
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/convert ‑ TestConvert_RemovesEscapeCharsAsV2AutoEscapes
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/convert ‑ TestConvert_WorksIfNoDeleteYamlExists
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/convert ‑ TestConvert_WorksOnFullConfiguration
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/convert ‑ TestCopyDeleteFileIfPresent
…

github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/integrationtest/account ‑ TestDeployAndDelete_AllResources
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/integrationtest/account ‑ TestIdempotenceOfDeployment

♻️ This comment has been updated with latest results.

@warber warber added run-iam-test Manually trigger Account Management E2E tests for PRs run-e2e-test Manually trigger the E2E tests for reviewed PRs and removed run-iam-test Manually trigger Account Management E2E tests for PRs run-e2e-test Manually trigger the E2E tests for reviewed PRs labels Oct 15, 2024
@warber warber force-pushed the fix/enable-rate-limiter-for-account-clients branch from 369d203 to c595f5a Compare October 15, 2024 09:25
@jskelin jskelin added the run-e2e-test Manually trigger the E2E tests for reviewed PRs label Oct 15, 2024
@warber warber force-pushed the fix/enable-rate-limiter-for-account-clients branch from c595f5a to 77eed91 Compare October 15, 2024 10:49
@warber warber marked this pull request as ready for review October 15, 2024 10:54
@warber warber requested a review from a team as a code owner October 15, 2024 10:54
@warber warber added run-iam-test Manually trigger Account Management E2E tests for PRs and removed run-e2e-test Manually trigger the E2E tests for reviewed PRs run-iam-test Manually trigger Account Management E2E tests for PRs labels Oct 15, 2024
jskelin
jskelin previously approved these changes Oct 15, 2024
View reviewed changes
.github/workflows/end-to-end-test.yml Outdated Show resolved Hide resolved
@warber warber removed the run-iam-test Manually trigger Account Management E2E tests for PRs label Oct 15, 2024
@warber warber force-pushed the fix/enable-rate-limiter-for-account-clients branch from 39b1997 to d07b81e Compare October 15, 2024 11:34
@warber warber added the run-iam-test Manually trigger Account Management E2E tests for PRs label Oct 15, 2024
@warber warber force-pushed the fix/enable-rate-limiter-for-account-clients branch from d07b81e to b0f4472 Compare October 15, 2024 13:50
jskelin
jskelin previously approved these changes Oct 15, 2024
View reviewed changes
@warber warber force-pushed the fix/enable-rate-limiter-for-account-clients branch from b0f4472 to 5c37108 Compare October 15, 2024 14:47
@warber warber force-pushed the fix/enable-rate-limiter-for-account-clients branch from 5c37108 to ee099f5 Compare October 15, 2024 14:52
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@warber warber merged commit 0e19c4d into main Oct 15, 2024
11 checks passed
@warber warber deleted the fix/enable-rate-limiter-for-account-clients branch October 15, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jskelin jskelin jskelin approved these changes

Assignees
No one assigned
Labels
run-iam-test Manually trigger Account Management E2E tests for PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@warber @jskelin