Fix missing verbose flag in legacy cli #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The verbose flag was missing in the flag definition and has now been added.
patrickpichler
requested review from
didiladi and
UnseenWizzard
and removed request for
didiladi
It makes more sense to have the verbose flag on a per command basis as on a global level. Hence it has been moved to be on a per command basis.
didiladi
approved these changes
Jan 25, 2021
didiladi
added a commit
that referenced
this pull request
Jan 26, 2021
This commit extends the documentation for `monaco` version 1.2.0 and sets its version. `monaco` 1.2.0 contains the following changes: Features: * 4c53146 #19: Download current environment configuration (#122) * dfbad92 and f54c278 Fix #45: Introduce new experimental cli design (#100) Bugfixes: * 211dcbe and b74b06b Fix missing verbose flag in legacy cli (#129) Misc changes: * c70ca7b Fix #82: Define some install steps/requirements (#109)
Merged
didiladi
added a commit
that referenced
this pull request
Jan 26, 2021
This commit extends the documentation for `monaco` version 1.2.0 and sets its version. `monaco` 1.2.0 contains the following changes: Features: * 4c53146 #19: Download current environment configuration (#122) * dfbad92 and f54c278 Fix #45: Introduce new experimental cli design (#100) Bugfixes: * 211dcbe and b74b06b Fix missing verbose flag in legacy cli (#129) Misc changes: * c70ca7b Fix #82: Define some install steps/requirements (#109)
didiladi
added a commit
that referenced
this pull request
Jan 26, 2021
This commit extends the documentation for `monaco` version 1.2.0 and sets its version. `monaco` 1.2.0 contains the following changes: Features: * 4c53146 and 8611bd5 #19: Download current environment configuration (#122) * dfbad92 and f54c278 Fix #45: Introduce new experimental cli design (#100) Bugfixes: * fe30566 Fix #136: Handle failing to find project-root-folder path (#137) * 211dcbe and b74b06b Fix missing verbose flag in legacy cli (#129) Misc changes: * c70ca7b Fix #82: Define some install steps/requirements (#109)
didiladi
added a commit
that referenced
this pull request
Jan 26, 2021
This commit extends the documentation for `monaco` version 1.2.0 and sets its version. `monaco` 1.2.0 contains the following changes: Features: * 4c53146 and 8611bd5 #19: Download current environment configuration (#122) * dfbad92 and f54c278 Fix #45: Introduce new experimental cli design (#100) Bugfixes: * fe30566 Fix #136: Handle failing to find project-root-folder path (#137) * 211dcbe and b74b06b Fix missing verbose flag in legacy cli (#129) Misc changes: * c70ca7b Fix #82: Define some install steps/requirements (#109)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The verbose flag was missing in the flag definition and has now been
added.