Fix test configs affected by breaking dashboard API #106 #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatomir146
previously approved these changes
Jan 18, 2021
This commit comments out integration test `TestIntegrationDoNotNormalizePathSeparatorsInUserAgentString` to prevent that this PR blocks other PRs in monaco. Interestingly, it fails just in the CI. When running it locally (against the same environments) it works just fine. The fixing of this test will happen in #121.
tatomir146
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the
ownerproperty to each dashboard config usedin the test configuration of
monaco. Since Dynatrace version 1.208+this is needed due to a breaking change in the dashboard API.