Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#7055: Migrate actions runner image from macOS 12 to macOS 13. #7094

Merged
merged 16 commits into from
Nov 27, 2024

Conversation

ivankyluk
Copy link
Contributor

@ivankyluk ivankyluk commented Nov 25, 2024

The macOS 12 Actions runner image will begin deprecation on 10/7/24 and will be fully unsupported by 12/3/24 for GitHub and ADO.

Please refer to actions/runner-images#10721 for details.

Updating the runner to macOS13 and DEVELOPER_DIR triggers unused-but-set-variable warnings.
Changed code to address unused-but-set-variable warnings by moving code under #ifdef, adding LOGs following CLIENT_ASSERT.

Fixes: #7055

@ivankyluk ivankyluk self-assigned this Nov 25, 2024
Copy link
Contributor

@derekbruening derekbruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for getting this working. I think we just want to avoid the nop LOG messages and checks and instead put the variables as DEBUG-only.

core/arch/x86/mangle.c Outdated Show resolved Hide resolved
clients/drcachesim/tests/core_sharded_test.cpp Outdated Show resolved Hide resolved
core/arch/x86/mangle.c Outdated Show resolved Hide resolved
core/arch/x86_code.c Outdated Show resolved Hide resolved
core/ir/instr_shared.c Outdated Show resolved Hide resolved
core/ir/x86/decode.c Outdated Show resolved Hide resolved
Copy link
Contributor

@derekbruening derekbruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meant to mark Approve since this probably doesn't need another look.

@ivankyluk ivankyluk merged commit cd2fc26 into master Nov 27, 2024
17 checks passed
@ivankyluk ivankyluk deleted the i7055-migrate-actions-runner-image-to-macOS13 branch November 27, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade from macOS 12 runner to 13 before 12/3/24
2 participants