i#6981: Use consistent version for upload-artifact and download-artifact #6983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the version used for upload-artifact and download-artifact to the current one recommended at https://github.com/actions/upload-artifact and https://github.com/actions/download-artifact. Fixes: #6981
derekbruening
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the version used for upload-artifact and download-artifact actions to the current one recommended at https://github.com/actions/upload-artifact and https://github.com/actions/download-artifact.
For these two actions, "v4" points to the latest available v4.x.x release, as evidenced by the commit hash for the versions at https://github.com/actions/download-artifact/tags and https://github.com/actions/upload-artifact/tags. So we would still be using the latest version as suggested by the security advisory for download-artifact (GHSA-cxww-7g56-2vh6).
PR #6964 bumped the download-artifact version but not the upload-artifact which caused a mismatch and the #6981 issue.
Test run worked fine: https://github.com/DynamoRIO/dynamorio/actions/runs/10835746272
Fixes: #6981