i#6938 sched migrate: Add lock contention stats #6968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds lock contention counters for mutex_dbg_owned::lock() in non-NDEBUG builds. While it's not there for release builds, the results in non-release should still be indicative of general lock behavior. Prints the stats for sched_lock_ with the other scheduler stats. Sample results on schedule_stats on a threadsig trace show a lot of contention even with only 3 cores: ``` $ clients/bin64/drmemtrace_launcher -indir ../build_x64_dbg_tests/drmemtrace.threadsig.5* -core_sharded -cores 3 -tool schedule_stats -verbose 1 [scheduler] Schedule lock acquired : 2196602 [scheduler] Schedule lock contended : 257580 ``` Issue: #6938
|
Relese build static drmemtrace tests (e.g., the burst_* ones) are all failing with floating point exceptions. It turns out it's due to different compilation units having different values for NDEBUG. I tried to make them all the same: but we have some files that contain |
|
win64 failure is drcacheoff.gencode callback.c assert #6081 |
brettcoon
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds lock contention counters for mutex_dbg_owned::lock() in non-NDEBUG builds.
While it's not there for release builds, the results in non-release should still be
indicative of general lock behavior.
When I just changed the mutex_dbg_owned header, the relese build static drmemtrace
tests (e.g., the burst_* ones) were all failing with floating point exceptions. It
turns out it's due to different compilation units having different values for NDEBUG.
I tried to make them all the same: but we have some files that contain
#undef NDEBUGand other complexities. So I split the mutex_dbg_owned implementation into a
.cpp file and have the mutex wrapper extra fields always present.
Prints the stats for sched_lock_ with the other scheduler stats.
Sample results on schedule_stats on a threadsig trace show a lot of contention even with only 3 cores:
Issue: #6938