Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#3544 RV64: Enable more tests on CI #6447

Merged
merged 8 commits into from
Nov 14, 2023
Merged

Conversation

ksco
Copy link
Contributor

@ksco ksco commented Nov 11, 2023

Enabling passed tests on RISC-V. Some extra work is necessary:

  • Implements insert_parameter_preparation() and mangle_syscall_arch() by shared them with AARCHXX.
  • Add currently unused SCRATCH_REG5 -- this allows us to share the code with AARCHXX more easily.
  • Implements mangle_insert_clone_code()

Issue: #3544

@ksco ksco removed the request for review from derekbruening November 11, 2023 20:38
@ksco
Copy link
Contributor Author

ksco commented Nov 12, 2023

x86-32-ubuntu22 tool.drcacheoff.simple #6416
x86-64-ubuntu22 api.rseq #6185

core/arch/mangle_shared.c Show resolved Hide resolved
@ksco
Copy link
Contributor Author

ksco commented Nov 14, 2023

@derekbruening vs2019-64 is failing because: There is not enough space on the disk.

@ksco
Copy link
Contributor Author

ksco commented Nov 14, 2023

Oh looks like vs2019-64 is running on a standard GA runner (Windows Server 2019), not a self-hosted one, so this could be an issue on Github side.

@ksco
Copy link
Contributor Author

ksco commented Nov 14, 2023

x86-32-ubuntu22 tool.drcacheoff.simple failed 5 times in a row: #6416

@ksco ksco merged commit 4cf500e into DynamoRIO:master Nov 14, 2023
15 checks passed
@ksco ksco deleted the i3544-enbale-tests branch November 14, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants