i#3544 RV64: Implement mangle_rel_addr() #6388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAL is the only instruction in RISC-V with PC-relative address reference, which needs to be mangled. Loading a PC-relative address into the thread pointer (tp) register should be rare and we left it unimplemented for now.
bete0
reviewed
Oct 24, 2023
bete0
reviewed
Oct 24, 2023
bete0
approved these changes
Oct 24, 2023
|
Looks like code_api|api.rseq test failed bu that might be #6185. |
Yes, it's an unstable test. |
|
@bete0 Can this be merged now? There is still one unresolved conversation so I'm not sure. |
|
Merging this as it’s already approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAL is the only instruction in RISC-V with PC-relative address reference, which needs to be mangled. Loading a PC-relative address into the thread pointer (tp) register should be rare and we left it unimplemented for now.