i#5843 scheduler: Fix record-replay ordinal mismatches #6236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a problem with the implementation of context switching on a blocking syscall: it was being done immediately upon seeing the maybe-blocking marker, which is right after the syscall instruction. This resulted in recording the syscall instruction ordinal as the switch point, when that ordinal is supposed to be exclusive and so needs to be right before the subsequent instruction. Adds a test that ensures we don't switch until after all the markers after a blocking syscall. Issue: #5843
Adds read-ahead to timestamps when replaying, to match ordinals when recording. Adds use of the just-read timestamp when skipping in the reader, to avoid losing the timestamp when the scheduler has read ahed. Adds recording of the ordinals at switch points in the unit tests for comprehensive testing of switch points instead of just testing thread sequences. Fixes several tests which were passing incorrect flags. Issue: #5843
|
ubuntu22 failure is api.rseq #6185 |
abhinav92003
approved these changes
Aug 2, 2023
kuhanov
added a commit
that referenced
this pull request
Aug 8, 2023
…om/DynamoRIO/dynamorio into aarch64_instruction_categorization * 'aarch64_instruction_categorization' of https://github.com/DynamoRIO/dynamorio: i#5843 scheduler: Fix record-replay ordinal mismatches (#6236) i#5843 scheduler: Delay switch to instr after blocking syscall (#6235)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds read-ahead to timestamps when replaying, to match record ordinals and not just instruction ordinals at start and switch points when recording.
Adds use of the just-read timestamp when skipping in the reader, to avoid losing the timestamp when the scheduler has read ahead.
Adds recording of the ordinals at switch points in the unit tests for comprehensive testing of switch points instead of just testing thread sequences.
Fixes several tests which were passing incorrect flags.
Issue: #5843