i#5383 mac a64, part 5: Get hello,world to run #6184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables BUILD_TESTS to compile for M1: a combination of fixing and disabling tests. Many issues came from assembler and pre-processor differences. Issue: #5383
…work with Mac assembler
Fixes global references in aarch64.asm which were loading the value instead of the address (the Linux a64 assembler auto-magically gives the address whether using ADD or LDR!). Fixes and clarifies the Mac64 x86 and arm TLS slots vs offsets. Uses gettimeofday() for query_time_seconds() instead of SYS_gettimeofday. Removes an invalid hardcoded 0 sysnum for global_do_syscall. Issue: #5383
abhinav92003
approved these changes
Jul 5, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
scattergather failed yet again #5329 |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Now hit api.rseq on ubuntu22: #6185 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes global references in aarch64.asm which were loading the value instead of the address (the Linux a64 assembler auto-magically gives the address whether using ADD or LDR!).
Fixes and clarifies the Mac64 x86 and arm TLS slots vs offsets.
Uses gettimeofday() for query_time_seconds() instead of SYS_gettimeofday.
Removes an invalid hardcoded 0 sysnum for global_do_syscall.
Issue: #5383