Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#4014 dr$sim phys: Export open-address hashtable from DR #5519

Merged
merged 3 commits into from
Jun 7, 2022

Conversation

derekbruening
Copy link
Contributor

For virtual-to-physical translation, we cannot use a 3rd-party library
such as STL due to static linking constraints. Yet the drcontainers
hashtable performs poorly; we need an open-address hashtable. Since
DR has one we export it here in a new interface.

Adds a simple test and documentation.

Issue: #4014

For virtual-to-physical translation, we cannot use a 3rd-party library
such as STL due to static linking constraints.  Yet the drcontainers
hashtable performs poorly; we need an open-address hashtable.  Since
DR has one we export it here in a new interface.

Adds a simple test and documentation.

Issue: #4014
@derekbruening
Copy link
Contributor Author

tool.drcachesim.scattergather is the 32-bit failure: #5329

ext/drcontainers/hashtable.h Show resolved Hide resolved
core/lib/dr_tools.h Show resolved Hide resolved
api/docs/release.dox Outdated Show resolved Hide resolved
@derekbruening
Copy link
Contributor Author

These flakes are getting more common: #5514 phys-threads, #4604 32-bit api.startstop sysenter.

@derekbruening derekbruening merged commit a3544c2 into master Jun 7, 2022
@derekbruening derekbruening deleted the i4014-dr-hashtable branch June 7, 2022 17:37
dolanzhao pushed a commit that referenced this pull request Jun 8, 2022
For virtual-to-physical translation, we cannot use a 3rd-party library
such as STL due to static linking constraints.  Yet the drcontainers
hashtable performs poorly; we need an open-address hashtable.  Since
DR has one we export it here in a new interface.

Adds a simple test and documentation.

Issue: #4014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants