Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#5505 kernel memtrace: Add submodule libipt & Initialize submodules all the time #5518

Merged
merged 8 commits into from
Jun 8, 2022

Conversation

dolanzhao
Copy link
Contributor

@dolanzhao dolanzhao commented Jun 6, 2022

  • Add libipt as a submodule
  • Tell GA CI to init submodules: submodules: true arg to checkout step
  • Add submodule update to make/git/devsetup.sh
  • Add submodule update to make/git/git_pullall.sh
  • Update how-to-build docs

Issue: #5505

- Add submodule update to make/git/devsetup.sh
- Add submodule update to make/git/git_pullall.sh
- Update how-to-build docs
@dolanzhao
Copy link
Contributor Author

#5515 (comment)

Potentially add a pre-commit hook to prevent the common mistake of accidentally rolling back a recent submodule update when switching branches

@derekbruening Could you explain this point in details?

@derekbruening
Copy link
Contributor

#5515 (comment)

Potentially add a pre-commit hook to prevent the common mistake of accidentally rolling back a recent submodule update when switching branches

@derekbruening Could you explain this point in details?

If you check out the drmemory repo and do "git grep submodule" you will see all the support it has: it is part of make/git/hook-pre-commit.sh that looks useful for the DR repo.

api/docs/building.dox Outdated Show resolved Hide resolved
.github/workflows/ci-package.yml Show resolved Hide resolved
make/git/git_pullall.sh Outdated Show resolved Hide resolved
make/git/git_pullall.sh Show resolved Hide resolved
make/git/git_pullall.sh Outdated Show resolved Hide resolved
- Add a pre-commit hook to prevent the common mistake of accidentally rolling back a recent submodule update when switching branches
- Fix the variable name error in copy code
@dolanzhao dolanzhao changed the title i#5517 add submodule libipt: Add libipt & Initialize submodules all the time i#5505 kernel memtrace: Add submodule libipt & Initialize submodules all the time Jun 7, 2022
make/git/hook-pre-commit.sh Show resolved Hide resolved
api/docs/building.dox Show resolved Hide resolved
make/git/hook-pre-commit.sh Outdated Show resolved Hide resolved
@abhinav92003
Copy link
Contributor

abhinav92003 commented Jun 8, 2022

Thanks for addressing the comments! In addition to commenting "done" in each conversation (which you did), please also click on the "resolve conversation" button so that it doesn't show up anymore.

@dolanzhao
Copy link
Contributor Author

Thanks for addressing the comments! In addition to commenting "done" in each conversation (which you did), please also click on the "resolve conversation" button so that it doesn't show up anymore.

OK. Thanks!

@abhinav92003
Copy link
Contributor

run arm tests

@dolanzhao dolanzhao merged commit bb80396 into master Jun 8, 2022
@dolanzhao dolanzhao deleted the i5517-add-submodule-libipt branch June 8, 2022 19:19
dolanzhao added a commit that referenced this pull request Jun 8, 2022
…time (#5518)

Adding libipt as a submodule and bringing up some bunch of additional support to ensure submodules can be initialized all the time:
- Tell GA CI to init submodules: submodules: true arg to checkout step
- Add submodule update to make/git/devsetup.sh
- Add submodule update to make/git/git_pullall.sh
- Update how-to-build docs
- Add a pre-commit hook to prevent the common mistake of accidentally rolling back a recent submodule update when switching branches

Issue: #5505
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants