i#4719 qemu: Add xarch_root option for QEMU #4726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new option -xarch_root which sets a path that is prepended to: + The application executable's interpreter, if the original does not exist. + SYS_openat paths, if the original does not exist. + System paths ued for loading private libraries: here the prefix is prepended before checking whether the original exists. Splits dynamorio_app_init() into two pieces in order to have the options set up at the time the loader maps the interpreter, while avoiding ordering problems with the rest of the initialization. The new option also auto-sets -ignore_takeover_timeout for convenience, as that is always needed when running under QEMU. Manually tested in cross-compile AArchXX setups on a Debian system. Test suite integration is forthcoming. Issue: #4719
…nitialized to false in standalone_exit
|
The failure is the low4G test. The problem is that the heap_in_lower_4GB option is now set during interp mapping, and it's used in os_map_file to add MAP_32BIT. DR's vmm is taking up a bunch of the low 2G and it seems the kernel won't put ld.so below it: Not sure of the cleanest fix...avoid the MAP_32BIT just for this mapping via some special flag or sthg? |
abhinav92003
approved these changes
Feb 9, 2021
MAP_FILE_APP to avoid MAP_32BIT on the app interpreter when -heap_in_lower_4GB is set, now that the options are parsed before we map the interpreter.
|
There are enough additions since the review it may be worth another look. |
abhinav92003
approved these changes
Feb 10, 2021
derekbruening
added a commit
that referenced
this pull request
Feb 11, 2021
Avoids printing of an internal warning during early initialization for single-bitwidth setups regardless of -stderr_mask by moving options init even earlier. To avoid DR heap init messing up the app's brk setup, moves heap init out of the options init and into the later half. This undoes the early heap init from PR #4726, which is worked around by switching to a stack buffer for -arch_init. This seems safer in any case, delaying heap init and client lib loads until after the app's interpreter is loaded. Issue: #4719
derekbruening
added a commit
that referenced
this pull request
Feb 11, 2021
Avoids printing of an internal warning during early initialization for single-bitwidth setups regardless of -stderr_mask by moving options init even earlier. To avoid DR heap init messing up the app's brk setup, moves heap init out of the options init and into the later half. This undoes the early heap init from PR #4726, which is worked around by switching to a stack buffer for -arch_init. This seems safer in any case, delaying heap init and client lib loads until after the app's interpreter is loaded. Moves the 1config file deletion from d_r_config_init() to -config_heap_init(), after any potential reload_dynamorio(). Issue: #4719
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new option -xarch_root which sets a path that is prepended to:
before checking whether the original exists.
Splits dynamorio_app_init() into two pieces in order to have the
options set up at the time the loader maps the interpreter, while
avoiding ordering problems with the rest of the initialization.
The new option also auto-sets -ignore_takeover_timeout for
convenience, as that is always needed when running under QEMU.
Manually tested in cross-compile AArchXX setups on a Debian system.
Test suite integration is forthcoming.
Issue: #4719