i#3315 memcpy conflict: fix Mac build #3375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns WEAK into a nop in asm files as the nasm assembler has no support for weak symbols, so we live with potential conflicts on Mac. Temporarily runs Mac on PR builds to ensure this fixes Mac on Travis (tested locally and it does fix it there). Issue: #3315
|
The appveyor failure is #3320. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns WEAK into a nop in asm files as the nasm assembler has no
support for weak symbols, so we live with potential conflicts on Mac.
Temporarily runs Mac on PR builds to ensure this fixes Mac on Travis
(tested locally and it does fix it there).
Issue: #3315