Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api.dis and decenc.drdecode_decenc_x86_64 failures in output matching #6411

Closed
derekbruening opened this issue Nov 6, 2023 · 2 comments
Closed

Comments

@derekbruening
Copy link
Contributor

This seems to have started recently (though xref #5725):

x64 Linux:
https://github.com/DynamoRIO/dynamorio/actions/runs/6752187857/job/18358030169

420/473 Test #422: code_api|api.dis .................................................***Failed    0.10 sec
CMake Error at /home/runner/work/dynamorio/dynamorio/suite/tests/runcmp.cmake:114 (message):
  failed to match expected output

Same failure on win64:
https://github.com/DynamoRIO/dynamorio/actions/runs/6775123864/job/18413681364?pr=6410

Similarly obscure failure in the same win64 run:

297/303 Test #290: code_api|decenc.drdecode_decenc_x86_64 ...........................***Failed    2.10 sec
CMake Error at D:/a/dynamorio/dynamorio/suite/tests/runcmp.cmake:114 (message):
  failed to match expected output

Did we change runcmp.cmake to not print out the diff?
I think PR #6254 is the culprit: that is why we now just have this opaque
message without details. So these may be the same as #5725.

@derekbruening
Copy link
Contributor Author

From #6428 (comment) adding the diff: this does look like #5725 so let's collapse into that one.

derekbruening pushed a commit that referenced this issue Nov 9, 2023
Use `find_program` to detect presence of the external diff command and,
if such a command is detected, print a full diff on failure to ease
debugging.

Issue: #6411
Related PR: #6254
@leewvic
Copy link

leewvic commented Nov 9, 2023

Attaching a diff output for the decoder problem. Current theory: there are some difference how AMD vs. Intel machines interpret the opcodes.
6_Run Suite.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants