Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android build failing due to NDK setup problems #5527

Closed
derekbruening opened this issue Jun 11, 2022 · 3 comments · Fixed by #5532
Closed

Android build failing due to NDK setup problems #5527

derekbruening opened this issue Jun 11, 2022 · 3 comments · Fixed by #5532
Labels
Component-Build Hotlist-ContinuousIntegration OpSys-Android Priority-High

Comments

@derekbruening
Copy link
Contributor

This started happening yesterday and has caused every Android build to fail, including the weekly package:

https://github.com/DynamoRIO/dynamorio/actions/runs/2478571712

https://github.com/DynamoRIO/dynamorio/runs/6840580519?check_suite_focus=true

...
2022-06-11 03:14:38 (67.2 MB/s) - ‘android-ndk-r10e-linux-x86_64.zip’ saved [1110915721/1110915721]
ERROR: Your ANDROID_NDK_ROOT variable does not point to a valid directory.
Error: Process completed with exit code 1.
@abhinav92003
Copy link
Contributor

@dolanzhao also hit this on #5515.

This was referenced Jun 13, 2022
Merged
Merged
@derekbruening
Copy link
Contributor Author

Android support is not in great shape in general: there are private loader problems on Android 9 #3543 and Android 10 #3683. (#5437's loader refactoring proposal may help there.)

There is DR-on-Android interest out there and there have been some PR's trying to improve things: maybe we should ask the community to help maintain by getting Android regression tests working. The current tiny set of regular maintainers just do not have the bandwidth to maintain Android and it would simplify things to drop Android support, unless more maintainers step up.

@derekbruening
Copy link
Contributor Author

I was going to mark the Android build as not required for PR merging -- but it's just part of the arm cross-compile job. Maybe we should split it out.

@dolanzhao dolanzhao mentioned this issue Jun 15, 2022
Merged
derekbruening pushed a commit that referenced this issue Jun 15, 2022
@dolanzhao
i#5527: Fix Android build broken by preset ANDROID_NDK_ROOT (#5532)
7facd0b 
Fixes the problem of NDK setup failing due to ANDROID_NDK_ROOT pointing to the wrong path. The GitHub VM system preset ANDROID_NDK_ROOT to a location which does not include the necessary resources that the setup process needs. We set the ANDROID_NDK_ROOT to the right location before running the setup script.

Fixed: #5527
derekbruening added a commit to DynamoRIO/drmemory that referenced this issue Aug 28, 2022
@derekbruening
Fix Android CI build
8e16972 
Mirrors the DynamoRIO/dynamorio#5527 fix by setting ANDROID_NDK_ROOT.
@derekbruening derekbruening mentioned this issue Aug 28, 2022
Merged
derekbruening added a commit to DynamoRIO/drmemory that referenced this issue Aug 28, 2022
@derekbruening
Fix Android CI build (#2460)
552c90d 
Mirrors the DynamoRIO/dynamorio#5527 fix by setting ANDROID_NDK_ROOT.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component-Build Hotlist-ContinuousIntegration OpSys-Android Priority-High
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

i#5527: fix android build broken by preset ANDROID_NDK_ROOT DynamoRIO/dynamorio
2 participants
@abhinav92003 @derekbruening