Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libipt as a submodule of dynamorio #5517

Closed
dolanzhao opened this issue Jun 6, 2022 · 1 comment
Closed

Add libipt as a submodule of dynamorio #5517

dolanzhao opened this issue Jun 6, 2022 · 1 comment
Assignees

Comments

@dolanzhao
Copy link
Contributor

Adding submodules in general brings up a bunch of auxiliary support we probably want. I wonder if we should separate this out as its own PR. I assume we want the submodule to be initialized all the time? If so, things we would want:

  • We have to tell GA CI to init submodules: submodules: true arg to checkout step
  • Add submodule update to make/git/devsetup.sh
  • Add submodule update to make/git/git_pullall.sh
  • Potentially add to how-to-build docs if not completely automated
  • Potentially add a pre-commit hook to prevent the common mistake of accidentally rolling back a recent submodule update when switching branches

Originally posted by @derekbruening in #5515 (comment)

@derekbruening
Copy link
Contributor

Not sure this needed to be its own issue? The reason libipt is desired is for dr$sim kernel traces #5505.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants