-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update drstrace and drltrace to use auto-generated syscall number files #1983
Comments
Unfortunately "Windows 10" doesn't tell us enough as its updates are major despite still being called "Windows 10": is this the just-out "Creators Update" 1703? If so, and the return value from drsys_init is DRMF_WARNING_UNSUPPORTED_KERNEL, this is not surprising. We should put the error message and syscall text file support that Dr. Memory uses from #1908 (xref e81c1cd) into drstrace to support major Windows updates with just a data file update. |
Right, but we never put the support into drstrace to read the syscall file: unfortunately it is only in drmemory right now. Putting a note into #1848 to include drstrace (and drltrace) in the solution there as well. |
Thanks for the quick reply.
|
Up, is there anything we can do to make drstrace work on Windows 10? |
You could take a stab at pointing to the syscall text file when drstrace initializes drsyscall, which is not much code: see the patch to drmemory/syscall.c from e81c1cd |
I was willing to do that but unfortunately I am not able to succesfuly build this project with command line on Windows |
I have the same problem - drstrace fails with above error. Using 64bit Windows 10: Microsoft Windows [Version 10.0.15063] |
The Windows build for the version 1.11.17622-1 available at https://github.com/DynamoRIO/drmemory/releases/download/cronbuild-1.11.17622/DrMemory-Windows-1.11.17622-1.zip does not contain this issue. Tested today on Windows 10 64bit. |
The problem still occurs with this build: C:\Program Files (x86)\Dr. Memory\bin64>drstrace.exe -- calc.exe PS C:\Users\vjard> [System.Environment]::OSVersion.Version 10 0 17134 0 |
This sound strange, because for me this version works fine. Perhaps, it depends not only on the Dr.Memory version?
|
Yours is 10.0.15063 What could I do to gather proper logs during init ? |
The future plan is to use auto-generated syscall numbers via #1848 rather than relying on tables that we have to manually update every 6 months for new Windows releases. This is already in Dr. Memory 2.1.0. This issue covers changing drstrace to use auto-generated syscall number files. |
Adds support for reading system call numbers from a text file to both drstrace and drltrace. Adds support for auto-generating that file, just like is done in Dr. Memory. Updates DR to 1713c2d2 to fix a decoder assert that breaks the auto-generation. Fixes #1983
Adds support for reading system call numbers from a text file to both drstrace and drltrace. Adds support for auto-generating that file, just like is done in Dr. Memory. Updates DR to 1713c2d2 to fix a decoder assert that breaks the auto-generation. Fixes #1983
The fix didn't make it for the July 5 cronbuild. It will be in the July 12 cronbuild. |
I have a fresh installation of Dr. Memory on a Windows 10 VM. When I run
bin\drstrace -- calc
and
bin64\drstrace -- calc
in cmd with administrator privilege I receive the error
ASSERT FAILURE: D:\drmemory_package\drstrace\drstrace.c:670: false (drsys failed to init)
and no output is produced.
The text was updated successfully, but these errors were encountered: