Fix CurtainPanel.ByElements bug (#3057)

REVIT-219424 * fix the node to return the list of curtain panels in a curtain wall in cases when some curtain panels are doors or windows
DynamoDS · Mar 26, 2024 · d7d5abb · d7d5abb
1 parent 448f29b
commit d7d5abb
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/.version b/.version
@@ -1 +1 @@
-0.6.12
+0.6.13
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+## 0.6.13
+* Fix CurtainPanel.ByElements displaying invalid ElementIds when Curtain Panels have their types changed to a different wall
+
 ## 0.6.12
 * Fix CurtainPanel.ByElements failing to return when there is a door or window present in the curtain wall
 

diff --git a/src/Libraries/RevitNodes/Elements/CurtainPanel.cs b/src/Libraries/RevitNodes/Elements/CurtainPanel.cs
@@ -380,7 +380,15 @@ public static CurtainPanel[] ByElement(Element hostingElement)
                     var panel = DocumentManager.Instance.CurrentDBDocument.GetElement(idPanel);
                     if (panel is Autodesk.Revit.DB.Panel)
                     {
-                        result.Add(CurtainPanel.FromExisting(panel as Autodesk.Revit.DB.Panel, true));
+                        ElementId hostPanelId = (panel as Panel).FindHostPanel();
+                        if (hostPanelId.IntegerValue != -1)
+                        {
+                            result.Add(null);
+                        }
+                        else
+                        {
+                            result.Add(CurtainPanel.FromExisting(panel as Autodesk.Revit.DB.Panel, true));
+                        }
                     }
                     else
                     {