Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DynamoSamples files #9879

Merged
merged 2 commits into from
Aug 5, 2019
Merged

Update DynamoSamples files #9879

merged 2 commits into from
Aug 5, 2019

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Aug 5, 2019

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

There are Dynamo basic samples containing nodes depending on Revit and as a result, the graph will run with warnings in other host and often times those nodes will not be resolved. I have removed the revit nodes in basic samples and move same samples into Revit folder.

Old Dynamo basic samples now become Revit samples.

New basic samples all run without warning in sandbox:
image

image

image

image

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

FYIs

@DynamoDS/dynamo @angelowang

@QilongTang QilongTang merged commit f3a9e76 into master Aug 5, 2019
@QilongTang QilongTang deleted the SamplesUpdate branch August 5, 2019 19:30
QilongTang added a commit that referenced this pull request Aug 5, 2019
* Update DynamoSamples files

* Update workspace names
QilongTang added a commit that referenced this pull request Aug 5, 2019
* Update DynamoSamples files

* Update workspace names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant