Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dynamo Projects to use latest IronPython 2.7.9 #9833

Merged
merged 1 commit into from
Jul 9, 2019

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Jul 8, 2019

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

Upgrade Dynamo VS Studio solution to reference latest IronPython 2.7.9. As a result of this PR, Microsoft.VisualStudio.CodeCoverage.Shim.dll will no longer be part of DynamoCore delivery. I believe there was no real hard dependency on that dll and we included that dll for some unknown reason..

That dll is no longer delivered as part of DynamicRuntimeLanguage 1.2.2 which IronPython 2.7.9 is depending on, see below image
image

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@QilongTang QilongTang added the DNM Do not merge. For PRs. label Jul 8, 2019
@mjkkirschner
Copy link
Member

@QilongTang if you are worried that integrators need that other dll for patching - we can just supply it as a post build step with a TODO and task to remove it later? - also thanks for jumping on this.

@@ -293,7 +293,7 @@
{
"ConcreteType": "Dynamo.Graph.Nodes.CodeBlockNodeModel, DynamoCore",
"NodeType": "CodeBlockNode",
"Code": "0;\n5;\n\"2.7.8\";",
"Code": "0;\n5;\n\"2.7.9\";",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, does the test rely on this string in any way?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@QilongTang QilongTang removed the DNM Do not merge. For PRs. label Jul 9, 2019
@QilongTang
Copy link
Contributor Author

QilongTang commented Jul 9, 2019

@aparajit-pratap @mjkkirschner @reddyashish Since our binary comparison job can only compare nugets and testing on this upgrade did not give my anything obvious yet (Self CI passed as well). I am going to merge this and do a binary comparison so we are sure about what dlls are affected.

@QilongTang
Copy link
Contributor Author

If needed, I can add dependency for https://www.nuget.org/packages/Microsoft.CodeCoverage/ in a separate PR

@QilongTang QilongTang merged commit b842a9e into master Jul 9, 2019
@QilongTang QilongTang deleted the IronPython2.7.9 branch July 9, 2019 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants