-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dynamo Projects to use latest IronPython 2.7.9 #9833
Conversation
@QilongTang if you are worried that integrators need that other dll for patching - we can just supply it as a post build step with a TODO and task to remove it later? - also thanks for jumping on this. |
@@ -293,7 +293,7 @@ | |||
{ | |||
"ConcreteType": "Dynamo.Graph.Nodes.CodeBlockNodeModel, DynamoCore", | |||
"NodeType": "CodeBlockNode", | |||
"Code": "0;\n5;\n\"2.7.8\";", | |||
"Code": "0;\n5;\n\"2.7.9\";", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, does the test rely on this string in any way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
@aparajit-pratap @mjkkirschner @reddyashish Since our binary comparison job can only compare nugets and testing on this upgrade did not give my anything obvious yet (Self CI passed as well). I am going to merge this and do a binary comparison so we are sure about what dlls are affected. |
If needed, I can add dependency for |
Please Note:
DynamoRevit
repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTM
label is added to the PR.Purpose
Upgrade Dynamo VS Studio solution to reference latest IronPython 2.7.9. As a result of this PR,
Microsoft.VisualStudio.CodeCoverage.Shim.dll
will no longer be part of DynamoCore delivery. I believe there was no real hard dependency on that dll and we included that dll for some unknown reason..That dll is no longer delivered as part of DynamicRuntimeLanguage 1.2.2 which IronPython 2.7.9 is depending on, see below image
Declarations
Check these if you believe they are true
*.resx
filesReviewers
@DynamoDS/dynamo
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of