Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamo Packages Host filters #9820

Merged
merged 21 commits into from
Jul 16, 2019
Merged

Dynamo Packages Host filters #9820

merged 21 commits into from
Jul 16, 2019

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Jun 28, 2019

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

This PR adds a host filter right next to the traditional package sorting option. I will look at illustrating the host dependencies on each package entry as well but the mock up data is not working for me. Regardless of that, the filter and package filtering code is done. Currently it is a global setting which will affect searched results and sorted results or any combination.

PackageManagerFilter_v3

image

image

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@DynamoDS/dynamo

FYIs

@gregmarr

@QilongTang QilongTang changed the title [ WIP ] Host filters [ WIP ] Dynamo Packages Host filters Jul 11, 2019
@QilongTang QilongTang changed the title [ WIP ] Dynamo Packages Host filters Dynamo Packages Host filters Jul 12, 2019
@QilongTang QilongTang added the PTAL Please Take A Look 👀 label Jul 12, 2019
@QilongTang
Copy link
Contributor Author

Not sure why the AppVeyor build failed, the following code should build fine but throwing errors on that VM.

        public List<FilterEntry> HostFilter
        {
            get => hostFilter;
            set
            {
                hostFilter = value;
                RaisePropertyChanged("HostFilter");
            }
        }

@QilongTang
Copy link
Contributor Author

It turns out the code above is in a newer .Net comes with VS 2019 which our build vm does not support yet, so I updated to use the traditional way.

@mjkkirschner
Copy link
Member

@QilongTang if you want to use that you'll need to swtich to using msbuild 15 I think on the build machine. Our docker image should support this already, but I am not sure about the main pipeline (and very likely not self serve)

<Reference Include="Greg, Version=1.0.6176.18754, Culture=neutral, processorArchitecture=MSIL">
<HintPath>..\packages\Greg.1.0.6176.18754\lib\net45\Greg.dll</HintPath>
<Reference Include="Greg, Version=1.2.7121.21318, Culture=neutral, processorArchitecture=MSIL">
<HintPath>..\packages\Greg.1.2.7121.21318\lib\net45\Greg.dll</HintPath>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should delete this project.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally, is this the js version pm client?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, we can remove this at any time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, seems it is in the repo but not part of the solution, so little risk

<Button Width="Auto"
Grid.Column="2"
Click="OnFilterButtonClicked"
fa:Awesome.Content="Filter"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of also adding a tooltip here? to the filter icon if it doesn't exist already?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can apply the same tooltip which I just added also to the context options, but the button I think need some different messaging?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjkkirschner More tooltips added

@QilongTang
Copy link
Contributor Author

@mjkkirschner Let me know if you prefer more changes on this one. Otherwise trying to get a real build by demo tomorrow

@mjkkirschner
Copy link
Member

@QilongTang LGTM - I had some alternative tooltip text for you to consider first though.

@QilongTang QilongTang removed the PTAL Please Take A Look 👀 label Jul 16, 2019
@QilongTang QilongTang merged commit f8cfc0a into master Jul 16, 2019
@QilongTang QilongTang deleted the PackageHostFilter branch July 16, 2019 02:25
mjkkirschner pushed a commit that referenced this pull request Aug 3, 2019
* Intial Commit

* Add Context Menu UI binding

* Add Calls to get supported hosts

* Some more code

* Clean Up

* Clean up

* Package dependency Search

* Add unfilter support

* Code Clean up and more elegent filter code

* Update the host dependencies getter

* Add package search element display of hosts

* Add style changes including fonts, vertical alignment, tooltip

* try to fix self CI

* Add unit test

* Remove the test added

* Address comments

* Add more tooltips

* Update Tooltips
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants