Fixes in computing function endpoints for replication cases #9632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reddyashish
reviewed
Apr 8, 2019
| a = [ 1, 2 ]; | ||
| b = [[3, 4], [5,9]]; | ||
| c = b[[true,0]][0..1]; // [[b[true][0], b[true, 1]], [b[0,0], b[0,1]]] => [null, [3, 4]] | ||
| test = foo (c, a[0..1]); "; |
There was a problem hiding this comment.
Minor change, extra spaces here at the end of the string.
|
@aparajit-pratap Looks good to me. |
mjkkirschner
reviewed
Apr 8, 2019
| a = [ 1, 2 ]; | ||
| b = [[3, 4], [5,9]]; | ||
| c = b[[0.1,1.1]][0..1]; | ||
| test = foo (c, a[0..1]);"; |
There was a problem hiding this comment.
isn't a[0..1] just equal to a?
|
LGTM |
reddyashish
added a commit
to reddyashish/Dynamo
that referenced
this pull request
May 21, 2019
7 tasks
QilongTang
pushed a commit
that referenced
this pull request
May 28, 2019
* Cherry-picking #9388 into 2.0.3 * Cherry-picking #9559 into 2.0.3 * Cherry-picking #9578 into 2.0.3 * cherry-picking #9632 into 2.0.3 * cherry-picking #9408 into 2.0.3 * cherry-picking #9441 into 2.0.3 * Adding gradient.png for the Test_PerforationsByImage test. This was missed while cherrypicking #9441 * Removing DSCoreDataTests.cs as this was the test fixture was introduced in a different commit and is not needed here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
https://jira.autodesk.com/browse/DYN-1759
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@reddyashish
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of