Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magn-9966 Crash when closing a Custom Node with a Group when in Sweden or France #6724

Merged
merged 6 commits into from
Jun 13, 2016

Conversation

sm6srw
Copy link
Contributor

@sm6srw sm6srw commented Jun 12, 2016

Purpose

Make sure that all convert methods are using the correct culture when converting to double. There are currently three different convert methods where we don't do that. These are:

ZoomToVisibilityConverter
MenuItemCheckConverter
GroupFontSizeToEditorEnabledConverter

These convert methods are in 99% of all cases passed a double at convert time and the current culture doesn't matter but there are a few cases where a string is passed in instead and that is when we will get invalid format exceptions in regions of the world that use "," instead of "." as the decimal point.

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • [] User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.

Reviewers

@ramramps

FYIs

@mjkkirschner @QilongTang

@ramramps
Copy link
Collaborator

LGTM

@sm6srw sm6srw merged commit 55e978b into master Jun 13, 2016
@sm6srw sm6srw deleted the MAGN-9966 branch June 13, 2016 13:35
@horatiubota horatiubota added the error/warning/crash Issues mentioning a Dynamo error, warning or crash message label Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
error/warning/crash Issues mentioning a Dynamo error, warning or crash message
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants