Magn-9966 Crash when closing a Custom Node with a Group when in Sweden or France #6724
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Make sure that all convert methods are using the correct culture when converting to double. There are currently three different convert methods where we don't do that. These are:
ZoomToVisibilityConverter
MenuItemCheckConverter
GroupFontSizeToEditorEnabledConverter
These convert methods are in 99% of all cases passed a double at convert time and the current culture doesn't matter but there are a few cases where a string is passed in instead and that is when we will get invalid format exceptions in regions of the world that use "," instead of "." as the decimal point.
Declarations
Check these if you believe they are true
*.resx
filesReviewers
@ramramps
FYIs
@mjkkirschner @QilongTang