-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-7693: Set geom scaling button setting to scale factor of current workspace model #15589
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7693
UI Smoke TestsTest: success. 11 passed, 0 failed. |
|
"Bindings": [], | ||
"View": { | ||
"Dynamo": { | ||
"ScaleFactor": 10000.0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
☝️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, would you add a screen shot of the UX diff. I believe the controls on canvas would reflect the scaleFactor better is the change right?
hey @aparajit-pratap can you explain what this change does to fix the issue? Is it just that we erroneously set the value to the scale factor raw value instead of the log of that value? Also - why do we do this - any idea what the benefit is? |
The geometry scale UI button reverts to the default setting every time I open the workflow. Is there a way of saving it with the dyn file. The geometry scale affects some of the functionality like Geometry.Intersect, so it is important to have the correct initial setting. Is there a way of setting the geometry scale from the API? |
Purpose
There's a bug with the geometry scale UI button (in the top-right corner of the canvas) where it doesn't always reflect the correct scale factor setting in a workspace. It can be reproduced specifically on a fresh launch of Dynamo and upon opening a graph with a non-default scale factor setting (other than medium). This PR attempts to fix the issue.
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Fixed a bug with the geometry scale UI button where it doesn't always reflect the correct scale factor setting in a workspace.
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of