Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-7693: Set geom scaling button setting to scale factor of current workspace model #15589

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

aparajit-pratap
Copy link
Contributor

@aparajit-pratap aparajit-pratap commented Nov 4, 2024

Purpose

There's a bug with the geometry scale UI button (in the top-right corner of the canvas) where it doesn't always reflect the correct scale factor setting in a workspace. It can be reproduced specifically on a fresh launch of Dynamo and upon opening a graph with a non-default scale factor setting (other than medium). This PR attempts to fix the issue.

scale_factor_demo

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Fixed a bug with the geometry scale UI button where it doesn't always reflect the correct scale factor setting in a workspace.

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@github-actions github-actions bot changed the title Set geom scaling button setting to scale factor of current workspace model DYN-7693: Set geom scaling button setting to scale factor of current workspace model Nov 4, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7693

Copy link

github-actions bot commented Nov 4, 2024

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@aparajit-pratap
Copy link
Contributor Author

Dynamo.Tests.ExcelTests+DSEvaluationModelTest.TestExcel is failing. I don't believe it's related.

"Bindings": [],
"View": {
"Dynamo": {
"ScaleFactor": 10000.0,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☝️

Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would you add a screen shot of the UX diff. I believe the controls on canvas would reflect the scaleFactor better is the change right?

@aparajit-pratap aparajit-pratap merged commit c8c0024 into DynamoDS:master Nov 5, 2024
26 checks passed
@aparajit-pratap aparajit-pratap deleted the dyn-7693 branch November 5, 2024 13:57
@QilongTang QilongTang added this to the 3.4 milestone Nov 5, 2024
aparajit-pratap added a commit to aparajit-pratap/Dynamo that referenced this pull request Nov 5, 2024
@mjkkirschner
Copy link
Member

mjkkirschner commented Nov 5, 2024

hey @aparajit-pratap can you explain what this change does to fix the issue? Is it just that we erroneously set the value to the scale factor raw value instead of the log of that value? Also - why do we do this - any idea what the benefit is?

@brianAboye
Copy link

The geometry scale UI button reverts to the default setting every time I open the workflow. Is there a way of saving it with the dyn file. The geometry scale affects some of the functionality like Geometry.Intersect, so it is important to have the correct initial setting.

Is there a way of setting the geometry scale from the API?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants