-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-7535 Record python engine package information in graphs when using engines served from them #15535
DYN-7535 Record python engine package information in graphs when using engines served from them #15535
Changes from 1 commit
3d0dd3a
48ba971
64402b4
2dae598
83d9caa
cde0786
ab9cc49
3bfc96a
790caba
9dde6f9
1b2fb95
943961d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
using System; | ||
using System.Collections.Generic; | ||
using System.Linq; | ||
using System.Reflection; | ||
using System.Xml; | ||
using Dynamo.Engine; | ||
using Dynamo.Engine.CodeGeneration; | ||
|
@@ -76,6 +77,23 @@ public override IdentifierNode GetAstIdentifierForOutputIndex(int outputIndex) | |
} | ||
} | ||
|
||
/// <summary> | ||
/// The method returns the assembly name from which the node originated. | ||
/// </summary> | ||
/// <returns>Assembly Name</returns> | ||
internal override AssemblyName GetNameOfAssemblyReferencedByNode() | ||
{ | ||
AssemblyName assemblyName = null; | ||
|
||
var descriptor = this.Controller.Definition; | ||
if (descriptor.IsPackageMember) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this would be valid even if this was not a packaged node -right? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, it would be, but I think the intent is to return null for non-packaged nodes. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. then I think your summary/returns could be updated to reflect that / a test should be added encoding that behavior. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sure, just want to add that this was the default behavior, I did not add this code but moved it inside the base class. So whatever it was doing before will still be applied. |
||
{ | ||
assemblyName = AssemblyName.GetAssemblyName(descriptor.Assembly); | ||
} | ||
|
||
return assemblyName; | ||
} | ||
|
||
/// <summary> | ||
/// Copy command will call it to serialize this node to xml data. | ||
/// </summary> | ||
|
@@ -358,4 +376,4 @@ protected override AssociativeNode GetFunctionApplication(NodeModel model, List< | |
return rhs; | ||
} | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe a better name is
GetOwningAssemblyNameOfNodeModel
- referenced by node sounds like a dependency of the node to me anyway.