Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-3674 ByMeshDisplay for the new Mesh type #15505

Merged
merged 14 commits into from
Nov 4, 2024
Merged

DYN-3674 ByMeshDisplay for the new Mesh type #15505

merged 14 commits into from
Nov 4, 2024

Conversation

LongNguyenP
Copy link
Contributor

@LongNguyenP LongNguyenP commented Sep 24, 2024

Purpose

This adds a DisplayColor node to support color of the Mesh Type. DYN-3674

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

The new Mesh nodes also have a node to set colors. They can be colored by a single color, per face, and per vertex.

Reviewers

@LongNguyenP @BogdanZavu

FYIs

@Amoursol @jnealb

@LongNguyenP LongNguyenP changed the title Added colored mesh display [WIP] MeshDiplay for the new Mesh type Sep 24, 2024
Copy link

github-actions bot commented Sep 24, 2024

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@saintentropy saintentropy changed the title [WIP] MeshDiplay for the new Mesh type DYN-3674 MeshDiplay for the new Mesh type Nov 3, 2024
@saintentropy saintentropy changed the title DYN-3674 MeshDiplay for the new Mesh type DYN-3674 ByMeshDisplay for the new Mesh type Nov 3, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-3674

@saintentropy saintentropy self-requested a review November 4, 2024 02:46
@saintentropy saintentropy merged commit 165f0a3 into master Nov 4, 2024
24 checks passed
@saintentropy saintentropy deleted the MeshDisplay branch November 4, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants