Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6385: Add missing documentation content for operator nodes #15436

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

zeusongit
Copy link
Contributor

Purpose

Added missing documentation content for operator nodes, since Windows do not allow file name including some special characters( like /,</>,* etc), we are making use of the hashed value for those operators, no code change is required.
Docs added for:

  • "/"
Screenshot 2024-08-19 at 5 36 33 PM
  • "*"
Screenshot 2024-08-19 at 5 36 14 PM
  • "+"
Screenshot 2024-08-19 at 5 49 10 PM
  • "<"
Screenshot 2024-08-19 at 5 37 47 PM
  • "<="
Screenshot 2024-08-19 at 5 38 23 PM
  • ">"
Screenshot 2024-08-19 at 5 38 05 PM
  • ">="
Screenshot 2024-08-19 at 5 38 40 PM
  • "||"
Screenshot 2024-08-19 at 5 35 48 PM

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • Added missing documentation content for operator nodes

Reviewers

@DynamoDS/dynamo

@github-actions github-actions bot changed the title add missing documentation content for operator nodes DYN-6385: add missing documentation content for operator nodes Aug 19, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6385

@zeusongit zeusongit changed the title DYN-6385: add missing documentation content for operator nodes DYN-6385: Add missing documentation content for operator nodes Aug 19, 2024
Copy link

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@zeusongit zeusongit added this to the 3.3 milestone Aug 19, 2024
@QilongTang
Copy link
Contributor

I guess only + is allowed among these cases? LGTM then

Copy link
Contributor

@RobertGlobant20 RobertGlobant20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zeusongit zeusongit merged commit 8e8f2d0 into DynamoDS:master Aug 20, 2024
25 of 27 checks passed
@zeusongit
Copy link
Contributor Author

I guess only + is allowed among these cases? LGTM then

Yes + is allowed but was missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants