Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6750 Update DynamoHome Version #15185

Merged
merged 1 commit into from
May 2, 2024
Merged

Conversation

QilongTang
Copy link
Contributor

Purpose

Follow up of DynamoDS/DynamoHome#14
DefaultActions

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Open and New button on Dynamo home now comes with a default action

Reviewers

FYIs

@DynamoDS/dynamo

@QilongTang QilongTang added this to the 3.2 milestone May 1, 2024
Copy link

github-actions bot commented May 1, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@QilongTang
Copy link
Contributor Author

QilongTang commented May 2, 2024

It's strange that one graph node manager test failed on this PR while the PR has nothing to do with Graph node manager, it passed locally, passed on master-15 self serve and release pipeline this week.

Merging and will trigger a release build

@QilongTang QilongTang merged commit 63c4f43 into master May 2, 2024
22 of 23 checks passed
@QilongTang QilongTang deleted the UpdateDynamoHomeVersion branch May 2, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants