Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6827 Graph properties should be displayed for Templates #15073

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

zeusongit
Copy link
Contributor

Purpose

Since template files do not have a filename, graph properties were being emptied, added a condition to check if the workspace is a template then skip clearing graph metadata.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • Graph properties should be displayed for Templates

Reviewers

@QilongTang

FYIs

@Amoursol

Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@QilongTang QilongTang added this to the 3.1 milestone Apr 1, 2024
@QilongTang QilongTang merged commit a39f243 into DynamoDS:master Apr 1, 2024
22 checks passed
@QilongTang QilongTang changed the title Graph properties should be displayed for Templates DYN-6827 Graph properties should be displayed for Templates Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants