Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: localized no-notifications message #15002

Conversation

Enzo707
Copy link
Contributor

@Enzo707 Enzo707 commented Mar 6, 2024

Purpose

This PR add the implementation for localized message when there's no notifications to show
Ref.: DYN-6484

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Implement message in resources NoNotificationsTitle and NoNotificationsMsg with respective text associated and expose setNoNotificationsTexts() through Windows object to make it accessible from NotificationCenter react component.

Reviewers

@QilongTang

Copy link

github-actions bot commented Mar 6, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@QilongTang QilongTang added this to the 3.1 milestone Mar 6, 2024
@QilongTang
Copy link
Contributor

The new npm package v0.0.29 has been published, merging

@QilongTang QilongTang merged commit 71d0a02 into DynamoDS:master Mar 6, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants