Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-Pick DYN-5791 Applying Renaming Tool (#14844) #14869

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Cherry-Pick DYN-5791 Applying Renaming Tool (#14844) #14869

merged 1 commit into from
Jan 19, 2024

Conversation

RobertGlobant20
Copy link
Contributor

Purpose

Cherry-Pick DYN-5791 Applying Renaming Tool (#14844)
PR: #14844

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Cherry-Pick DYN-5791 Applying Renaming Tool (#14844)

Reviewers

@QilongTang

FYIs

@reddyashish

* DYN-5791 Applying Renaming Tool

The renaming tool with my fix was applied in the next folder doc\distrib\NodeHelpFiles\
Some of the files already renamed were deleted, otherwise the tool throws an exception that the file already exists.

* DYN-5791 Applying Renaming Tool

Updating manually 2 files due that the image name inside the original md file is not the same than the real image (then was not passing the 70 chars limit) then the renaming tool was not processing this case.

* DYN-5791 Applying Renaming Tool Code Review

Added the word "plus" because the renaming tool is replacing the "+" char by empty space.
@QilongTang QilongTang added this to the 3.0.3 milestone Jan 19, 2024
@QilongTang QilongTang merged commit 438a6c7 into DynamoDS:RC3.0.3_master Jan 19, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants