Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Watch3D nodes to run in software mode #14650

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Conversation

sm6srw
Copy link
Contributor

@sm6srw sm6srw commented Nov 28, 2023

Purpose

This pull request does:

  • allow Watch3D nodes to run in software mode.

I think this is a leftover since the days when we supported WIndows 7/8. As far as I know, at least a software render should always be available in Windows 10/11.

This change also allows all Dynamo tests to pass on an ECS instance with GPU. These instances behaves as a multi GPU machine and for some reason, the RenderCapability object reports nothing useful. But everything points to that Dynamo is in hardware mode and the RenderMode object indicates this.

I will also try to run all tests on an instance without GPU.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@sm6srw sm6srw added the DNM Do not merge. For PRs. label Nov 28, 2023
@sm6srw sm6srw changed the title This is just a test, ignore Allow Watch3D nodes to run in software mode Nov 29, 2023
@sm6srw sm6srw removed the DNM Do not merge. For PRs. label Nov 29, 2023
@sm6srw sm6srw merged commit 0a0a313 into DynamoDS:master Nov 30, 2023
20 of 21 checks passed
@sm6srw sm6srw deleted the watch3d_test branch November 30, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants