my packages empty screen user not logged in #14610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- now displays empty screen message if the user has not logged in
reddyashish
reviewed
Nov 14, 2023
| @@ -634,8 +639,6 @@ private void PopulateMyPackages() | |||
| // We should have already populated the CachedPackageList by this step | |||
| if (PackageManagerClientViewModel.CachedPackageList == null || | |||
| !PackageManagerClientViewModel.CachedPackageList.Any()) return; | |||
| // We need the user to be logged in, otherwise there is no point in runnig this routine | |||
| if (PackageManagerClientViewModel.LoginState != Greg.AuthProviders.LoginState.LoggedIn) return; | |||
There was a problem hiding this comment.
Shouldn't we return here in PopulateMyPackages() if the user is not logged in?
There was a problem hiding this comment.
We are, we are! This was an odd one, I don't know if it was me who coded this previously, but we had this check twice in a roll, which doesn't make any sense. Check out a tiny bit further down line 464:
The only difference is that we are initializing the SearchMyResults, so it's not a null anymore, which allows us to set the screen later on.
reddyashish
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
A new empty screen message added when the user has not logged in. When going to the
MyPackagestab, if the user has not logged in yet, the following screen will prompt them to.Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@reddyashish
FYIs
@Amoursol