Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

single New Package Download Path #14559

Merged
merged 3 commits into from
Nov 4, 2023

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Nov 2, 2023

Purpose

Small change to only show the currently selected Package Download path instead of the full list of paths. Since the PreferenceViewModel may not have been initialized yet, we assign the value from the PreferencesSettings ourselves, which is what the PreferenceViewModel will do when initialized.

image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • just shows the currently selected package download path

Reviewers

@reddyashish

FYIs

@Amoursol

- just shows the currently selected package download path
@QilongTang QilongTang added this to the 3.0 milestone Nov 3, 2023
@reddyashish reddyashish merged commit 0304338 into DynamoDS:master Nov 4, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants