Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-5745 feat(Library): add full text selection for search bar input #14516

Conversation

Enzo707
Copy link
Contributor

@Enzo707 Enzo707 commented Oct 24, 2023

Screen Recording 2023-10-24 at 14 17 33

Purpose

This PR includes changes for full text selection in Library search bar input using Ctrl + A
Ref.: PR 195

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Implements a method in search bar that creates a selectionRange based on the current input value when we press Ctrl + A

Reviewers

@QilongTang

FYIs

@avidit

@QilongTang QilongTang added this to the 3.0 milestone Oct 24, 2023
@QilongTang QilongTang merged commit 16425c6 into DynamoDS:master Oct 24, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants