Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package zoom out state #14507

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Oct 22, 2023

Purpose

Adjusting zoomed-out states behavior to favor Package over Preview state:

zoomed-in

image

zoomed-out

image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • changed order of zoom out states to favor package over preview off
  • priorities are Error > Warning > Info ; Frozen > Package > Preview > None

Reviewers

@Amoursol
@reddyashish

FYIs

dnenov and others added 2 commits October 22, 2023 12:04
- changed order of zoom out states to favor package over preview off
- priorities are Error > Warning > Info ; Frozen > Package > Preview > None
@QilongTang QilongTang added this to the 3.0 milestone Oct 23, 2023
using System.Text.RegularExpressions;
using System.Windows;
using System.Windows.Controls.Primitives;
using System.Windows.Media;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment

@QilongTang QilongTang merged commit 892253e into DynamoDS:master Oct 24, 2023
19 of 20 checks passed
@QilongTang
Copy link
Contributor

QilongTang commented Oct 24, 2023

@dnenov Oops, I accidentally merged this one, I will cover the using order in my other PR so don't worry about it. Also, can you re-attach the screenshot for the zoomed-out state, the resolution is not good enough.

@dnenov
Copy link
Collaborator Author

dnenov commented Oct 25, 2023

@dnenov Oops, I accidentally merged this one, I will cover the using order in my other PR so don't worry about it. Also, can you re-attach the screenshot for the zoomed-out state, the resolution is not good enough.

Updated the image as needed, @QilongTang! I also made the change in VS so the order of the namespaces should be good from now on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants