-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package zoom out state #14507
package zoom out state #14507
Conversation
- changed order of zoom out states to favor package over preview off - priorities are Error > Warning > Info ; Frozen > Package > Preview > None
using System.Text.RegularExpressions; | ||
using System.Windows; | ||
using System.Windows.Controls.Primitives; | ||
using System.Windows.Media; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please refer to https://github.com/DynamoDS/Dynamo/wiki/Coding-Standards#usings and revert such change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one comment
@dnenov Oops, I accidentally merged this one, I will cover the using order in my other PR so don't worry about it. Also, can you re-attach the screenshot for the zoomed-out state, the resolution is not good enough. |
Updated the image as needed, @QilongTang! I also made the change in VS so the order of the namespaces should be good from now on. |
Purpose
Adjusting zoomed-out states behavior to favor Package over Preview state:
zoomed-in
zoomed-out
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Reviewers
@Amoursol
@reddyashish
FYIs