Dynamo 2.16.2 Hotfix #14157
Merged
Dynamo 2.16.2 Hotfix #14157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix Trusted Message behavior * Extract Business Logic as a function * Moving API to Preferences * Adding unit test
#13437) * Leave RP data intact * Fix tests * Remove unnessary code * Spelling typos and clean up * clean up * clean up * Add regression test for render package mutation. * Unsubscribe from event. * Add image comparison test for render bug. * Fix test image size. Co-authored-by: Craig Long <[email protected]> Co-authored-by: Trygve Wastvedt <[email protected]>
* Insert the export command in the shortcut view model * remove test method
* DYN-5317-Check-WebView2-Installed I added a validation that before starting the DynamoSandbox app we will check if the WebView2 Runtime is installed or not, if is not installed we will show a MessageBox with the link of the WebView2 installer and then after pressing the OK button close Dynamo. Also in the DynamoMessageBox I added a RichTextBox that will be visible under very specific circumstances, this RichTextBox allows to have a blue hyperlink as a part of the text so the user can click it and open the webview2 installer webpage. * DYN-5317-Check-WebView2-Installed removing extra comment
After the auto-save functionality is triggered when we are located in the Custom Node edit tab when the node in the Home Workspace is being renamed to "backup". Then after my fix first is checking if it has a name and file associated (that usually happen when you create/edit a custom node) if that is the case then we don't execute the rename process. Also I added a test that will validate that the Save functionality doesn't rename the CustomNode name.
|
The EngOps build failure is expected with different version of ASM dependency on master branch |
zeusongit
reviewed
Jul 13, 2023
| @@ -119,9 +119,10 @@ private void InsertPath() | |||
| return; | |||
| } | |||
|
|
|||
| TrustedLocations.Insert(TrustedLocations.Count, args.Path); | |||
| TrustedLocations.Insert(TrustedLocations.Count, args.Path); | |||
There was a problem hiding this comment.
Yeah this belongs to the original PR cherry-picked
zeusongit
approved these changes
Jul 13, 2023
|
LGTM @QilongTang 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Cherry-picking:
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Mandatory section
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of