DYN-5844 color picker scrollbar #14033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: changing the width and adding a scrollbar due that when showing the ColorPicker under a Windows Scale =175% some buttons are hidden
fix: bug that is hiding some ColorPicker controls when the scale > 100% I've done several changes in the CustomColorPicker basically removing some of the hardcoded Width and Height values and also I've added a Vertical Scroll Bar that will be only visible when some controls of the Popup are hidden.
|
GIF showing the behavior when the Scale = 100% |
|
GIF showing the behavior when the Scale = 75% |
avidit
approved these changes
May 30, 2023
avidit
changed the title
QilongTang
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
fix: bug that is hiding some ColorPicker controls when the machine scale > 100%
I've done several changes in the CustomColorPicker basically removing some of the hardcoded Width and Height values and also I've added a Vertical Scroll Bar that will be only visible when some controls of the Popup are hidden.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
fixing bug that is hiding some ColorPicker controls when the machine scale > 100%
Reviewers
@QilongTang
FYIs
@avidit