Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DYN-5862 Python editor docking improvements #13984

Merged
merged 9 commits into from
May 17, 2023
Merged

DYN-5862 Python editor docking improvements #13984

merged 9 commits into from
May 17, 2023

Conversation

reddyashish
Copy link
Contributor

@reddyashish reddyashish commented May 12, 2023 •
edited
Loading

Purpose

A followup PR to #13957

Addressed the points mentioned in this task: https://jira.autodesk.com/browse/DYN-5862

  1. Node rename should rename the docked python editor tab name.
  2. Change the name SideBar Panel to Sidebar
  3. Engine name is set when the editor is opened in docked state.
  4. Changing the engine name and clicking on save & run button should update the engine name.
  5. Improved the python editor docking behavior inside a custom node.

python docking improvements

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Python editor docking improvements

Reviewers

@QilongTang @zeusongit

@avidit avidit changed the title Python editor docking improvements DYN-5862 Python editor docking improvements May 12, 2023
@reddyashish
Copy link
Contributor Author

Same flaky tests which are passing locally.

@QilongTang QilongTang added this to the 2.19.0 milestone May 17, 2023
QilongTang
QilongTang reviewed May 17, 2023
View reviewed changes
Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall solid improvements, one thing I forgot to ask before. Can we add analytics tracking for Python node docking/undocking for usage tracking?

@reddyashish
Copy link
Contributor Author

reddyashish commented May 17, 2023 •
edited
Loading

@QilongTang I have now added the analytics tracking for docking/undocking for python node windows explicitly.

@reddyashish
Copy link
Contributor Author

@QilongTang good to merge this?

@QilongTang QilongTang merged commit 993587d into DynamoDS:master May 17, 2023
Enzo707 pushed a commit to Enzo707/Dynamo that referenced this pull request May 22, 2023
@reddyashish @Enzo707
DYN-5862 Python editor docking improvements (DynamoDS#13984)
ebe6c31 
* Python docking improvements

* Update resources

* update

* Update ScriptEditorWindow.xaml.cs

* update CachedEngine when editor engine is changed in docked state

* Improvement python editor behavior inside a custom node.

* Update DynamoViewModel.cs

* Addressing comments

* Update PythonNode.cs
@reddyashish reddyashish mentioned this pull request Jul 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avidit avidit avidit left review comments

@QilongTang QilongTang QilongTang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@reddyashish @avidit @QilongTang