Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support enum default values in imported zt methods #13925

Merged
merged 6 commits into from
Apr 25, 2023

Conversation

mjkkirschner
Copy link
Member

Purpose

#13671
https://jira.autodesk.com/browse/DYN-5506

at @aparajit-pratap's suggestion - instead of trying to generate and cast and int to an enum when we encounter an enum default value - instead generate a get method call for the generated getter which represents the specific enum field. This works as Enum types are imported into the VM as classes.

a test is added.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

support enum default values in zero touch import

Reviewers

@mjkkirschner mjkkirschner merged commit a8f45b4 into DynamoDS:master Apr 25, 2023
@mjkkirschner mjkkirschner deleted the ztenum branch April 25, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants