Fix Civil3D hostname to fix psuedo warning for package users #13910
Conversation
| /// as there is a mismatch between the host dependency name in packages and the host name used by Civil 3D for Dynamo. | ||
| /// </summary> | ||
| private readonly string Civil3DHostName = "Dynamo Civil 3D"; | ||
| private readonly string oldCivil3DHostName = "Civil 3D"; |
There was a problem hiding this comment.
hmm it's a bit weird to define this in the Dynamo code base, should we switch to a more tolerant match based on your earlier comment?
There was a problem hiding this comment.
just curious - could we do this transformation at runtime on the package manager? (not actually modify the package entries on disk) ... I prefer this because we don't need to update dynamo to fix the issue.
There was a problem hiding this comment.
@mjkkirschner Do you mean adding the hostname in the hosts returned from Package Manager?
here: https://git.autodesk.com/Dynamo/PackageManager/blob/c1e6047b5a92419049098c4a478bfb463aed6aae/src/app.js#L239
There was a problem hiding this comment.
hmm it's a bit weird to define this in the Dynamo code base, should we switch to a more tolerant match based on your earlier comment?
@QilongTang updated with more tolerant approach
There was a problem hiding this comment.
no, I mean that when package manager encounters a package with this old hostname to just return the new one instead in the response when the user downloads this package or gets its header... but perhaps this has issues with the pkg.json?
|
looks like a sporadic failure. Running the job again: https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/8921/ |
|
Cherrypick this? |
…S#13910) * add cache * add new host name check * Update PackageManagerExtension.cs * Update PackageManagerExtension.cs * Update PackageManagerExtension.cs * Update PackageManagerExtension.cs * Update PackageManagerExtension.cs
…#13935) * add cache * add new host name check * Update PackageManagerExtension.cs * Update PackageManagerExtension.cs * Update PackageManagerExtension.cs * Update PackageManagerExtension.cs * Update PackageManagerExtension.cs
Purpose
https://jira.autodesk.com/browse/DYN-5470
Added
Dynamo Civil 3Das the hostname for Civil 3D packages that haveCivil 3Das the host dependency.Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@DynamoDS/dynamo